isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix underflow checl in fill_args().

Browse Source
This commit is contained in:
Todd C. Miller
2016-07-16 20:54:07 -06:00
parent 88ba54f478
commit 73b0ac4bc1
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/sudoers/toke_util.c
View File

@@ -153,7 +153,8 @@ fill_args(const char *s, size_t len, int addspace)
p = sudoerslval.command.args + arg_len; p = sudoerslval.command.args + arg_len;
if (addspace) if (addspace)
*p++ = ' '; *p++ = ' ';
if (strlcpy(p, s, arg_size - (p - sudoerslval.command.args)) != (size_t)len) { len = arg_size - (p - sudoerslval.command.args);
if (strlcpy(p, s, len) != len) {
sudo_warnx(U_("internal error, %s overflow"), __func__); sudo_warnx(U_("internal error, %s overflow"), __func__);
goto bad; goto bad;
} }