isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix potential leak of evlog->runuser.

Browse Source 
Also warn if we find an unexpected JSON type.
This commit is contained in:
Todd C. Miller
2021-02-02 10:27:27 -07:00
parent eec4f42366
commit 71997da168
1 changed files with 9 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
lib/iolog/iolog_json.c
View File

@@ -197,7 +197,7 @@ json_store_runuser(struct json_item *item, struct eventlog *evlog)
{ {
debug_decl(json_store_runuser, SUDO_DEBUG_UTIL); debug_decl(json_store_runuser, SUDO_DEBUG_UTIL);
free(evlog->rungroup); free(evlog->runuser);
evlog->runuser = item->u.string; evlog->runuser = item->u.string;
item->u.string = NULL; item->u.string = NULL;
debug_return_bool(true); debug_return_bool(true);
@@ -412,7 +412,15 @@ free_json_items(struct json_item_list *items)
case JSON_OBJECT: case JSON_OBJECT:
free_json_items(&item->u.child.items); free_json_items(&item->u.child.items);
break; break;
case JSON_ID:
case JSON_NUMBER:
case JSON_BOOL:
case JSON_NULL:
/* Nothing to free. */
break;
default: default:
sudo_warnx("%s: internal error, invalid JSON type %d",
__func__, item->type);
break; break;
} }
free(item->name); free(item->name);