isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix potential stack overflow due to infinite recursion in alias

Browse Source 
cycle detection.  From Daniel Kopecek.
This commit is contained in:
Todd C. Miller
2013-01-23 07:52:09 -05:00
parent ef8e141248
commit 6fe6ccb048
1 changed files with 2 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/sudoers/visudo.c
View File

@@ -1066,18 +1066,16 @@ alias_remove_recursive(char *name, int type)
bool rval = true; bool rval = true;
debug_decl(alias_remove_recursive, SUDO_DEBUG_ALIAS) debug_decl(alias_remove_recursive, SUDO_DEBUG_ALIAS)
if ((a = alias_find(name, type)) != NULL) { if ((a = alias_remove(name, type)) != NULL) {
tq_foreach_fwd(&a->members, m) { tq_foreach_fwd(&a->members, m) {
if (m->type == ALIAS) { if (m->type == ALIAS) {
if (!alias_remove_recursive(m->name, type)) if (!alias_remove_recursive(m->name, type))
rval = false; rval = false;
} }
} }
rbinsert(alias_freelist, a);
} }
alias_seqno++; alias_seqno++;
a = alias_remove(name, type);
if (a)
rbinsert(alias_freelist, a);
debug_return_bool(rval); debug_return_bool(rval);
} }