Minor style nit.

This commit is contained in:
Todd C. Miller
2022-03-16 15:53:17 -06:00
parent 6143dcae97
commit 6af2b4188a

View File

@@ -92,8 +92,8 @@ sudo_krb5_setup(struct passwd *pw, char **promptp, sudo_auth *auth)
static char *krb5_prompt; static char *krb5_prompt;
debug_decl(sudo_krb5_init, SUDOERS_DEBUG_AUTH); debug_decl(sudo_krb5_init, SUDOERS_DEBUG_AUTH);
/* Don't set prompt if user has set a custom one with -p */ /* Don't overrride the prompt if the user specified their own. */
if (promptp && strcmp(*promptp, PASSPROMPT)) { if (strcmp(*promptp, PASSPROMPT) != 0) {
debug_return_int(AUTH_SUCCESS); debug_return_int(AUTH_SUCCESS);
} }
@@ -117,14 +117,11 @@ sudo_krb5_setup(struct passwd *pw, char **promptp, sudo_auth *auth)
debug_return_int(AUTH_FAILURE); debug_return_int(AUTH_FAILURE);
} }
/* Only rewrite prompt if user didn't specify their own. */
/*if (!strcmp(prompt, PASSPROMPT)) { */
if (asprintf(&krb5_prompt, "Password for %s: ", pname) == -1) { if (asprintf(&krb5_prompt, "Password for %s: ", pname) == -1) {
log_warningx(0, N_("unable to allocate memory")); log_warningx(0, N_("unable to allocate memory"));
free(pname); free(pname);
debug_return_int(AUTH_FATAL); debug_return_int(AUTH_FATAL);
} }
/*}*/
free(pname); free(pname);
} }
*promptp = krb5_prompt; *promptp = krb5_prompt;