isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Only log "a password is required" for "sudo -n" if a command is specified.

Browse Source 
This means that it is not logged for "sudo -nv" and "sudo -nl".
We only log this message when sudo's -n flag is specified (and not
when the user presses ^C at the password prompt) so that there is
a record of failed non-interactive commands.
This commit is contained in:
Todd C. Miller
2024-01-10 13:54:41 -07:00
parent b39dc7c5f1
commit 67e328d6f8
1 changed files with 8 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
plugins/sudoers/logging.c
View File

@@ -1,7 +1,7 @@
/* /*
* SPDX-License-Identifier: ISC * SPDX-License-Identifier: ISC
* *
* Copyright (c) 1994-1996, 1998-2023 Todd C. Miller <Todd.Miller@sudo.ws> * Copyright (c) 1994-1996, 1998-2024 Todd C. Miller <Todd.Miller@sudo.ws>
* *
* Permission to use, copy, modify, and distribute this software for any * Permission to use, copy, modify, and distribute this software for any
* purpose with or without fee is hereby granted, provided that the above * purpose with or without fee is hereby granted, provided that the above
@@ -507,9 +507,14 @@ log_auth_failure(const struct sudoers_context *ctx, unsigned int status,
/* Do auditing first (audit_failure() handles the locale itself). */ /* Do auditing first (audit_failure() handles the locale itself). */
audit_failure(ctx, ctx->runas.argv, "%s", N_("authentication failure")); audit_failure(ctx, ctx->runas.argv, "%s", N_("authentication failure"));
/* If sudoers denied the command we'll log that separately. */ if (ISSET(status, FLAG_NO_USER_INPUT)) {
if (!ISSET(status, FLAG_BAD_PASSWORD|FLAG_NO_USER_INPUT)) /* For "sudo -n", only log the entry if an actual command was run. */
if (ISSET(ctx->mode, MODE_LIST|MODE_VALIDATE))
logit = false;
} else if (!ISSET(status, FLAG_BAD_PASSWORD)) {
/* Autheticated OK, sudoers denials are logged separately. */
logit = false; logit = false;
}
/* /*
* Do we need to send mail? * Do we need to send mail?