isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make sure groupname_len is at least 32 just to be on the safe side.

Browse Source 
It is better to allocate a little extra and not need it than to
have to reallocate and start over.
This commit is contained in:
Todd C. Miller
2013-03-05 14:06:51 -05:00
parent 4e5baccb9c
commit 593832152f
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/sudoers/pwutil_impl.c
View File

@@ -271,10 +271,10 @@ sudo_make_grlist_item(struct passwd *pw)
#endif #endif
#if defined(HAVE_SYSCONF) && defined(_SC_LOGIN_NAME_MAX) #if defined(HAVE_SYSCONF) && defined(_SC_LOGIN_NAME_MAX)
groupname_len = (int)sysconf(_SC_LOGIN_NAME_MAX); groupname_len = MAX((int)sysconf(_SC_LOGIN_NAME_MAX), 32);
if (groupname_len < 0) #else
groupname_len = MAX(LOGIN_NAME_MAX, 32);
#endif #endif
groupname_len = LOGIN_NAME_MAX;
/* Allocate in one big chunk for easy freeing. */ /* Allocate in one big chunk for easy freeing. */
nsize = strlen(pw->pw_name) + 1; nsize = strlen(pw->pw_name) + 1;