isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't leak temp fd in sudo_edit_copy_tfiles().

Browse Source 
Fix fd leak in error path in sudo_edit_copy_tfiles().
This commit is contained in:
Todd C. Miller
2014-08-25 10:42:59 -06:00
parent 8ad53f458e
commit 5676d9874d
1 changed files with 3 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/sudo_edit.c
View File

@@ -228,6 +228,8 @@ sudo_edit_create_tfiles(struct command_details *command_details,
sudo_warn("%s", tf[j].tfile); sudo_warn("%s", tf[j].tfile);
else else
sudo_warnx(U_("%s: short write"), tf[j].tfile); sudo_warnx(U_("%s: short write"), tf[j].tfile);
close(ofd);
close(tfd);
debug_return_int(-1); debug_return_int(-1);
} }
} }
@@ -342,6 +344,7 @@ sudo_edit_copy_tfiles(struct command_details *command_details,
sudo_warnx(U_("contents of edit session left in %s"), tf[i].tfile); sudo_warnx(U_("contents of edit session left in %s"), tf[i].tfile);
} }
close(ofd); close(ofd);
close(tfd);
} }
debug_return_int(errors); debug_return_int(errors);
} }