isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions 1 Packages Projects Releases Wiki Activity

If inet_addr() returns INADDR_NONE, return false instead of iterating

Browse Source 
through the interfaces looking for a match that will never happen.
This commit is contained in:
Todd C. Miller
2014-01-22 20:48:49 -07:00
parent cf6bca1390
commit 4c9650f78f
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
plugins/sudoers/match_addr.c
View File

@@ -66,8 +66,10 @@ addr_matches_if(const char *n)
} else } else
#endif /* HAVE_STRUCT_IN6_ADDR */ #endif /* HAVE_STRUCT_IN6_ADDR */
{ {
family = AF_INET;
addr.ip4.s_addr = inet_addr(n); addr.ip4.s_addr = inet_addr(n);
if (addr.ip4.s_addr == INADDR_NONE)
debug_return_bool(false);
family = AF_INET;
} }
SLIST_FOREACH(ifp, get_interfaces(), entries) { SLIST_FOREACH(ifp, get_interfaces(), entries) {
@@ -118,8 +120,10 @@ addr_matches_if_netmask(const char *n, const char *m)
else else
#endif /* HAVE_STRUCT_IN6_ADDR */ #endif /* HAVE_STRUCT_IN6_ADDR */
{ {
family = AF_INET;
addr.ip4.s_addr = inet_addr(n); addr.ip4.s_addr = inet_addr(n);
if (addr.ip4.s_addr == INADDR_NONE)
debug_return_bool(false);
family = AF_INET;
} }
if (family == AF_INET) { if (family == AF_INET) {