Mark functions not returning as sudo_noreturn

We also put NOTREACHED where it applies.

logsrvd/logsrvd.c

@@ -1973,7 +1973,7 @@ main(int argc, char *argv[])
 	    break;
 	case 'h':
 	    help();
-	    break;
+	    /* NOTREACHED */
 	case 'n':
 	    nofork = true;
 	    break;

logsrvd/regress/logsrvd_conf/logsrvd_conf_test.c

@@ -38,7 +38,7 @@
 
 sudo_dso_public int main(int argc, char *argv[]);
 
-static void
+sudo_noreturn static void
 usage(void)
 {
     fprintf(stderr, "usage: %s [-v] conf_file\n", getprogname());
@@ -64,6 +64,7 @@ main(int argc, char *argv[])
 	    break;
 	default:
 	    usage();
+	    /* NOTREACHED */
 	}
     }
     argc -= optind;

logsrvd/sendlog.c

@@ -1703,7 +1703,7 @@ main(int argc, char *argv[])
 
     /* Read sudo.conf and initialize the debug subsystem. */
     if (sudo_conf_read(NULL, SUDO_CONF_DEBUG) == -1)
-        exit(EXIT_FAILURE);
+        return EXIT_FAILURE;
     sudo_debug_register(getprogname(), NULL, NULL,
         sudo_conf_debug_files(getprogname()), -1);
 
@@ -1746,7 +1746,7 @@ main(int argc, char *argv[])
 	    break;
 	case 1:
 	    help();
-	    break;
+	    /* NOTREACHED */
 #if defined(HAVE_OPENSSL)
 	case 'b':
 	    ca_bundle = optarg;
@@ -1767,6 +1767,7 @@ main(int argc, char *argv[])
 	    return 0;
 	default:
 	    usage(true);
+	    /* NOTREACHED */
 	}
     }
     argc -= optind;