isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix iteration over runas_groups list.

Browse Source
This commit is contained in:
Todd C. Miller
2010-03-22 18:08:17 -04:00
parent 8df6ba9fee
commit 43ea59f64f
1 changed files with 6 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/sudo.c
View File

@@ -402,6 +402,7 @@ command_info_to_details(char * const info[], struct command_details *details)
} }
for (i = 0; info[i] != NULL; i++) { for (i = 0; info[i] != NULL; i++) {
sudo_debug(9, "command info: %s", info[i]);
switch (info[i][0]) { switch (info[i][0]) {
case 'c': case 'c':
SET_STRING("chroot=", chroot) SET_STRING("chroot=", chroot)
@@ -499,10 +500,12 @@ command_info_to_details(char * const info[], struct command_details *details)
for (j = 0; j < details->ngroups;) { for (j = 0; j < details->ngroups;) {
errno = 0; errno = 0;
ulval = strtoul(cp, &ep, 0); ulval = strtoul(cp, &ep, 0);
if (*cp != '\0' && (*ep == ',' || *ep == '\0') && if (*cp == '\0' || (*ep != ',' && *ep != '\0') ||
(errno != ERANGE || ulval != ULONG_MAX)) { (ulval == ULONG_MAX && errno == ERANGE)) {
details->groups[j++] = (gid_t)ulval; break;
} }
details->groups[j++] = (gid_t)ulval;
cp = ep + 1;
} }
details->ngroups = j; details->ngroups = j;
break; break;
@@ -678,7 +681,6 @@ exec_setup(struct command_details *details)
} }
if (!ISSET(details->flags, CD_PRESERVE_GROUPS)) { if (!ISSET(details->flags, CD_PRESERVE_GROUPS)) {
/* XXX - may need to initgroups anyway--plugin may not have list */
#ifdef HAVE_GETGROUPS #ifdef HAVE_GETGROUPS
if (details->ngroups >= 0) { if (details->ngroups >= 0) {
if (setgroups(details->ngroups, details->groups) < 0) { if (setgroups(details->ngroups, details->groups) < 0) {