isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

When calling setauthdb(), save the old registry value so we can

Browse Source 
restore it properly.  Previously we were setting the registry to
unrestricted instead of actually restoring it.
This commit is contained in:
Todd C. Miller
2016-01-22 17:04:58 -07:00
parent 578be4f39c
commit 41a32a1c58
4 changed files with 86 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
lib/util/aix.c
View File

@@ -129,8 +129,15 @@ aix_setlimits(char *user)
#ifdef HAVE_SETAUTHDB
# ifndef HAVE_AUTHDB_T
typedef char authdb_t[16];
# endif
/* The empty string means to access all defined administrative domains. */
static authdb_t old_registry;
# if defined(HAVE_DECL_SETAUTHDB) && !HAVE_DECL_SETAUTHDB
int setauthdb(char *new, char *old);
int setauthdb(authdb_t new, authdb_t old);
# endif
# if defined(HAVE_DECL_USRINFO) && !HAVE_DECL_USRINFO
int usrinfo(int cmd, char *buf, int count);
@@ -156,7 +163,7 @@ aix_setauthdb_v1(char *user)
goto done;
}
if (getuserattr(user, S_REGISTRY, &registry, SEC_CHAR) == 0) {
if (setauthdb(registry, NULL) != 0) {
if (setauthdb(registry, old_registry) != 0) {
sudo_warn(U_("unable to switch to registry \"%s\" for %s"),
registry, user);
goto done;
@@ -181,7 +188,7 @@ aix_restoreauthdb_v1(void)
int rval = 0;
debug_decl(aix_setauthdb, SUDO_DEBUG_UTIL)
if (setauthdb(NULL, NULL) != 0) {
if (setauthdb(old_registry, NULL) != 0) {
sudo_warn(U_("unable to restore registry"));
rval = -1;
}