Add missing PVS Studio Open Source comments.

Also avoid checking protobuf-c source and protobuf-c generated files.
2022-06-29 09:45:04 -06:00
parent e5834bd405
commit 3e21c8da5c
23 changed files with 99 additions and 33 deletions
--- a/lib/eventlog/Makefile.in
+++ b/lib/eventlog/Makefile.in
@@ -93,11 +93,6 @@ CHECK_WRAP_OBJS = check_wrap.lo logwrap.lo

 all: libsudo_eventlog.la

-pvs-log-files: $(POBJS)
-
-pvs-studio: $(POBJS)
-	plog-converter $(PVS_LOG_OPTS) $(POBJS)
-
 depend:
 	$(scriptdir)/mkdep.pl --srcdir=$(abs_top_srcdir) \
 	    --builddir=$(abs_top_builddir) lib/eventlog/Makefile.in
@@ -147,6 +142,9 @@ cppcheck:

 pvs-log-files: $(POBJS)

+pvs-studio: $(POBJS)
+	plog-converter $(PVS_LOG_OPTS) $(POBJS)
+
 fuzz:

 check-fuzzer:
--- a/lib/fuzzstub/Makefile.in
+++ b/lib/fuzzstub/Makefile.in
@@ -88,11 +88,6 @@ POBJS = $(IOBJS:.i=.plog)

 all: libsudo_fuzzstub.la

-pvs-log-files: $(POBJS)
-
-pvs-studio: $(POBJS)
-	plog-converter $(PVS_LOG_OPTS) $(POBJS)
-
 depend:
 	$(scriptdir)/mkdep.pl --srcdir=$(abs_top_srcdir) \
 	    --builddir=$(abs_top_builddir) lib/fuzzstub/Makefile.in
@@ -139,6 +134,9 @@ cppcheck:

 pvs-log-files: $(POBJS)

+pvs-studio: $(POBJS)
+	plog-converter $(PVS_LOG_OPTS) $(POBJS)
+
 fuzz:

 check-fuzzer:
--- a/lib/iolog/Makefile.in
+++ b/lib/iolog/Makefile.in
@@ -140,11 +140,6 @@ FUZZ_IOLOG_TIMING_CORPUS = $(srcdir)/regress/corpus/seed/timing/timing.*

 all: libsudo_iolog.la

-pvs-log-files: $(POBJS)
-
-pvs-studio: $(POBJS)
-	plog-converter $(PVS_LOG_OPTS) $(POBJS)
-
 depend:
 	$(scriptdir)/mkdep.pl --srcdir=$(abs_top_srcdir) \
 	    --builddir=$(abs_top_builddir) lib/iolog/Makefile.in
@@ -305,6 +300,9 @@ cppcheck:

 pvs-log-files: $(POBJS)

+pvs-studio: $(POBJS)
+	plog-converter $(PVS_LOG_OPTS) $(POBJS)
+
 fuzz: run-fuzz_iolog_json run-fuzz_iolog_legacy run-fuzz_iolog_timing

 check-fuzzer: $(FUZZ_PROGS)
--- a/lib/iolog/host_port.c
+++ b/lib/iolog/host_port.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #ifdef HAVE_STDBOOL_H
--- a/lib/logsrv/Makefile.in
+++ b/lib/logsrv/Makefile.in
@@ -86,11 +86,6 @@ GENERATED = log_server.pb-c.h log_server.pb-c.c

 all: liblogsrv.la

-pvs-log-files: $(POBJS)
-
-pvs-studio: $(POBJS)
-	plog-converter $(PVS_LOG_OPTS) $(POBJS)
-
 depend:
 	$(scriptdir)/mkdep.pl --srcdir=$(abs_top_srcdir) \
 	    --builddir=$(abs_top_builddir) lib/logsrv/Makefile.in
@@ -149,7 +144,9 @@ splint:
 cppcheck:
 	cppcheck $(CPPCHECK_OPTS) -I$(incdir) -I$(top_builddir) -I$(top_srcdir) $(srcdir)/*.c

-pvs-log-files: $(POBJS)
+pvs-log-files:
+
+pvs-studio:

 fuzz:

--- a/lib/protobuf-c/Makefile.in
+++ b/lib/protobuf-c/Makefile.in
@@ -81,11 +81,6 @@ POBJS = $(IOBJS:.i=.plog)

 all: libprotobuf-c.la

-pvs-log-files: $(POBJS)
-
-pvs-studio: $(POBJS)
-	plog-converter $(PVS_LOG_OPTS) $(POBJS)
-
 depend:
 	$(scriptdir)/mkdep.pl --srcdir=$(abs_top_srcdir) \
 	    --builddir=$(abs_top_builddir) lib/protobuf-c/Makefile.in
@@ -144,7 +139,9 @@ splint:
 cppcheck:
 	cppcheck $(CPPCHECK_OPTS) -I$(incdir) -I$(top_builddir) -I$(top_srcdir) $(srcdir)/*.c

-pvs-log-files: $(POBJS)
+pvs-log-files:
+
+pvs-studio:

 fuzz:

--- a/lib/util/Makefile.in
+++ b/lib/util/Makefile.in
@@ -197,11 +197,6 @@ FUZZ_SUDO_CONF_CORPUS = $(srcdir)/regress/corpus/seed/sudo_conf/sudo.conf.*

 all: libsudo_util.la

-pvs-log-files: $(POBJS)
-
-pvs-studio: $(POBJS)
-	plog-converter $(PVS_LOG_OPTS) $(POBJS)
-
 depend: siglist.c signame.c
 	$(scriptdir)/mkdep.pl --srcdir=$(abs_top_srcdir) \
 	    --builddir=$(abs_top_builddir) lib/util/Makefile.in
@@ -395,6 +390,9 @@ cppcheck:

 pvs-log-files: $(POBJS)

+pvs-studio: $(POBJS)
+	plog-converter $(PVS_LOG_OPTS) $(POBJS)
+
 fuzz: run-fuzz_sudo_conf

 check-fuzzer: $(FUZZ_PROGS)
--- a/lib/util/getentropy.c
+++ b/lib/util/getentropy.c
@@ -20,6 +20,11 @@
 * http://man.openbsd.org/getentropy.2
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #ifndef HAVE_GETENTROPY
--- a/lib/util/roundup.c
+++ b/lib/util/roundup.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #include "sudo_compat.h"
--- a/logsrvd/iolog_writer.c
+++ b/logsrvd/iolog_writer.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #include <sys/stat.h>
--- a/logsrvd/logsrv_util.c
+++ b/logsrvd/logsrv_util.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #include <sys/types.h>
--- a/logsrvd/logsrvd.c
+++ b/logsrvd/logsrvd.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #include <sys/stat.h>
--- a/logsrvd/logsrvd_conf.c
+++ b/logsrvd/logsrvd_conf.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #include <sys/stat.h>
--- a/logsrvd/logsrvd_journal.c
+++ b/logsrvd/logsrvd_journal.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #include <sys/stat.h>
--- a/logsrvd/logsrvd_local.c
+++ b/logsrvd/logsrvd_local.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #include <sys/stat.h>
--- a/logsrvd/logsrvd_queue.c
+++ b/logsrvd/logsrvd_queue.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #include <sys/stat.h>
--- a/logsrvd/logsrvd_relay.c
+++ b/logsrvd/logsrvd_relay.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #include <sys/stat.h>
--- a/logsrvd/sendlog.c
+++ b/logsrvd/sendlog.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #include <sys/stat.h>
--- a/logsrvd/tls_client.c
+++ b/logsrvd/tls_client.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #include <errno.h>
--- a/logsrvd/tls_init.c
+++ b/logsrvd/tls_init.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #ifdef HAVE_STDBOOL_H
--- a/plugins/sudoers/log_client.c
+++ b/plugins/sudoers/log_client.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #ifdef SUDOERS_LOG_CLIENT
--- a/src/Makefile.in
+++ b/src/Makefile.in
@@ -146,7 +146,7 @@ OBJS = conversation.o copy_file.o edit_open.o env_hooks.o exec.o exec_common.o \
       net_ifs.o parse_args.o preserve_fds.o signal.o sudo.o sudo_edit.o \
       suspend_nopty.o tcsetpgrp_nobg.o tgetpass.o ttyname.o utmp.o @SUDO_OBJS@

-IOBJS = $(OBJS:.o=.i) sesh.i
+IOBJS = $(OBJS:.o=.i) sesh.i sudo_intercept.i sudo_intercept_common.i

 POBJS = $(IOBJS:.i=.plog)

--- a/src/apparmor.c
+++ b/src/apparmor.c
@@ -16,6 +16,11 @@
 * OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
 */

+/*
+ * This is an open source non-commercial project. Dear PVS-Studio, please check it.
+ * PVS-Studio Static Code Analyzer for C, C++ and C#: http://www.viva64.com
+ */
+
 #include <config.h>

 #ifdef HAVE_APPARMOR