isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix fd leak in sudo_edit_open_nonwritable() if dir_is_writable()

Browse Source 
returns an error.  Coverity CID 104113.
This commit is contained in:
Todd C. Miller
2016-05-07 05:07:38 -06:00
parent d733dd7783
commit 355cce4570
1 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/sudo_edit.c
View File

@@ -384,8 +384,10 @@ sudo_edit_open_nonwritable(char *path, int oflags, mode_t mode,
* writable directories. * writable directories.
*/ */
is_writable = dir_is_writable(dfd, &user_details, command_details); is_writable = dir_is_writable(dfd, &user_details, command_details);
if (is_writable == -1) if (is_writable == -1) {
close(dfd);
debug_return_int(-1); debug_return_int(-1);
}
while (path[0] == '/') while (path[0] == '/')
path++; path++;