isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Fix potential NULL pointer deference found by clang-analyzer.

Browse Source
This commit is contained in:
Todd C. Miller
2022-07-26 11:44:12 -06:00
parent f5dc739ea3
commit 3421c8b6ce
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/util/sudo_debug.c
View File

@@ -861,7 +861,7 @@ sudo_debug_execve2_v1(int level, const char *path, char *const argv[], char *con
continue; continue;
/* Log envp for debug level "debug". */ /* Log envp for debug level "debug". */
if (output->settings[subsys] >= SUDO_DEBUG_DEBUG - 1 && envp[0] != NULL) if (output->settings[subsys] >= SUDO_DEBUG_DEBUG - 1 && envp != NULL)
log_envp = true; log_envp = true;
/* Alloc and build up buffer. */ /* Alloc and build up buffer. */
@@ -873,7 +873,7 @@ sudo_debug_execve2_v1(int level, const char *path, char *const argv[], char *con
buflen += strlen(*av) + 1; buflen += strlen(*av) + 1;
buflen--; buflen--;
} }
if (envp != NULL && log_envp) { if (log_envp && envp[0] != NULL) {
buflen += sizeof(" []") - 1; buflen += sizeof(" []") - 1;
for (av = envp; *av; av++) for (av = envp; *av; av++)
buflen += strlen(*av) + 1; buflen += strlen(*av) + 1;
@@ -904,7 +904,7 @@ sudo_debug_execve2_v1(int level, const char *path, char *const argv[], char *con
cp[-1] = ']'; cp[-1] = ']';
} }
if (envp != NULL && log_envp) { if (log_envp && envp[0] != NULL) {
*cp++ = ' '; *cp++ = ' ';
*cp++ = '['; *cp++ = '[';
for (av = envp; *av; av++) { for (av = envp; *av; av++) {