isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Don't set owner/mode on directories that already exist, only on

Browse Source 
newly-created ones.
This commit is contained in:
Todd C. Miller
2017-03-21 14:55:19 -06:00
parent 1bd90d8fff
commit 2caddff3f9
1 changed files with 1 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/sudoers/mkdir_parents.c
View File

@@ -66,14 +66,7 @@ sudo_mkdir_parents(char *path, uid_t uid, gid_t gid, mode_t mode, bool quiet)
sudo_warn(U_("unable to stat %s"), path); sudo_warn(U_("unable to stat %s"), path);
goto bad; goto bad;
} }
if (S_ISDIR(sb.st_mode)) { if (!S_ISDIR(sb.st_mode)) {
if (uid != (uid_t)-1 && gid != (gid_t)-1) {
if (sb.st_uid != uid || sb.st_gid != uid)
ignore_result(chown(path, uid, uid));
}
if ((sb.st_mode & ALLPERMS) != mode)
ignore_result(chmod(path, mode));
} else {
if (!quiet) if (!quiet)
sudo_warnx(U_("%s exists but is not a directory (0%o)"), sudo_warnx(U_("%s exists but is not a directory (0%o)"),
path, (unsigned int) sb.st_mode); path, (unsigned int) sb.st_mode);