From 2c06aa321b0aaa89ff174e6e7482e65f0e430874 Mon Sep 17 00:00:00 2001 From: "Todd C. Miller" Date: Sat, 11 Nov 2023 08:19:19 -0700 Subject: [PATCH] cvtsudoers_ldif: display warning on write error --- plugins/sudoers/cvtsudoers_ldif.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/plugins/sudoers/cvtsudoers_ldif.c b/plugins/sudoers/cvtsudoers_ldif.c index f5f9e3aff..00ed18a30 100644 --- a/plugins/sudoers/cvtsudoers_ldif.c +++ b/plugins/sudoers/cvtsudoers_ldif.c @@ -783,13 +783,17 @@ convert_sudoers_ldif(const struct sudoers_parse_tree *parse_tree, goto cleanup; } + ret = true; + cleanup: if (seen_users != NULL) rbdestroy(seen_users, seen_user_free); (void)fflush(output_fp); - if (!ferror(output_fp)) - ret = true; + if (ferror(output_fp)) { + sudo_warn("%s", output_file); + ret = false; + } if (output_fp != stdout) fclose(output_fp);