isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Simple garbage collection (really a to-be-freed list) for the sudoers

Browse Source 
plugin.  Almost identical to what sudo.c uses.  Currenly only the
environment strings are collected at exit time which is enough to
quiet address sanitizer's leak detector.
This commit is contained in:
Todd C. Miller
2016-01-28 14:53:48 -07:00
parent 7b2fbed45d
commit 21d6fc3d8f
5 changed files with 174 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/sudoers/env.c
View File

@@ -1,5 +1,5 @@
/*
* Copyright (c) 2000-2005, 2007-2015
* Copyright (c) 2000-2005, 2007-2016
* Todd C. Miller <Todd.Miller@courtesan.com>
*
* Permission to use, copy, modify, and distribute this software for any
@@ -412,6 +412,8 @@ sudo_setenv2(const char *var, const char *val, bool dupcheck, bool overwrite)
}
if (rval == -1)
free(estring);
else
sudoers_gc_add(GC_PTR, estring);
debug_return_int(rval);
}
@@ -468,6 +470,8 @@ sudo_setenv_nodebug(const char *var, const char *val, int overwrite)
done:
if (rval == -1)
free(estring);
else
sudoers_gc_add(GC_PTR, estring);
return rval;
}
@@ -972,6 +976,7 @@ rebuild_env(void)
free(cp);
goto bad;
}
sudoers_gc_add(GC_PTR, cp);
}
} else {
/*
@@ -1060,6 +1065,7 @@ rebuild_env(void)
free(cp);
goto bad;
}
sudoers_gc_add(GC_PTR, cp);
} else {
CHECK_SETENV2("SUDO_COMMAND", user_cmnd, true, true);
}
@@ -1217,6 +1223,7 @@ read_env_file(const char *path, int overwrite)
memcpy(cp, var, var_len + 1); /* includes '=' */
memcpy(cp + var_len + 1, val, val_len + 1); /* includes NUL */
sudoers_gc_add(GC_PTR, cp);
if (sudo_putenv(cp, true, overwrite) == -1) {
/* XXX - no undo on failure */
rval = false;