isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add a check for devname() returning a fully-qualified pathname.

Browse Source 
None of the devname() implementations do this today but you never
know when this might change.
This commit is contained in:
Todd C. Miller
2012-01-12 07:50:40 -05:00
parent 315b998a6d
commit 1c038be413
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/sudo.c
View File

@@ -479,12 +479,15 @@ get_process_tty(void)
sudo_debug_printf(SUDO_DEBUG_WARN, sudo_debug_printf(SUDO_DEBUG_WARN,
"unable to map device number %u to name", "unable to map device number %u to name",
ki_proc->sudo_kp_tdev); ki_proc->sudo_kp_tdev);
} else { } else if (*dev != '/') {
/* devname() doesn't use the /dev/ prefix, add one... */ /* devname() doesn't use the /dev/ prefix, add one... */
size_t len = sizeof(_PATH_DEV) + strlen(dev); size_t len = sizeof(_PATH_DEV) + strlen(dev);
tty = emalloc(len); tty = emalloc(len);
strlcpy(tty, _PATH_DEV, len); strlcpy(tty, _PATH_DEV, len);
strlcat(tty, dev, len); strlcat(tty, dev, len);
} else {
/* Should not happen but just in case... */
tty = estrdup(dev);
} }
} else { } else {
sudo_debug_printf(SUDO_DEBUG_WARN, sudo_debug_printf(SUDO_DEBUG_WARN,