isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Always allocate a pty when running a command in the background but

Browse Source 
call setsid() after forking to make sure we don't end up with a
controlling tty.
This commit is contained in:
Todd C. Miller
2011-05-27 15:20:20 -04:00
parent 8513c48185
commit 1b67009ca1
1 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
src/exec.c
View File

@@ -216,7 +216,9 @@ sudo_execve(struct command_details *details, struct command_status *cstat)
cstat->val = errno;
return -1;
case 0:
/* child continues */
/* child continues in a new session in a different pty */
SET(details->flags, CD_USE_PTY);
(void)setsid();
break;
default:
/* parent exits */
@@ -231,12 +233,10 @@ sudo_execve(struct command_details *details, struct command_status *cstat)
*/
if (!tq_empty(&io_plugins) || ISSET(details->flags, CD_USE_PTY)) {
log_io = TRUE;
if (!ISSET(details->flags, CD_BACKGROUND)) {
if (ISSET(details->flags, CD_SET_UTMP))
utmp_user = details->utmp_user ? details->utmp_user : user_details.username;
sudo_debug(8, "allocate pty for I/O logging");
pty_setup(details->euid, user_details.tty, utmp_user);
}
if (ISSET(details->flags, CD_SET_UTMP))
utmp_user = details->utmp_user ? details->utmp_user : user_details.username;
sudo_debug(8, "allocate pty for I/O logging");
pty_setup(details->euid, user_details.tty, utmp_user);
}
/*