isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Use PATH_MAX, not NAME_MAX+1 for the directory entry length.

Browse Source 
On some systems, such as Solaris, the max length of a directory
entry is filesystem-dependent.  We could use fpathconf() and
dynamically allocate the name but it is simpler to just use
PATH_MAX here.
This commit is contained in:
Todd C. Miller
2022-01-12 15:30:39 -07:00
parent 853e710f4a
commit 1afce22f7f
1 changed files with 1 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
lib/util/mkdir_parents.c
View File

@@ -82,6 +82,7 @@ bool
sudo_mkdir_parents_v1(const char *path, uid_t uid, gid_t gid, mode_t mode, bool quiet) sudo_mkdir_parents_v1(const char *path, uid_t uid, gid_t gid, mode_t mode, bool quiet)
{ {
const char *cp, *ep, *pathend; const char *cp, *ep, *pathend;
char name[PATH_MAX];
bool ret = false; bool ret = false;
int parentfd; int parentfd;
debug_decl(sudo_mkdir_parents, SUDO_DEBUG_UTIL); debug_decl(sudo_mkdir_parents, SUDO_DEBUG_UTIL);
@@ -106,8 +107,6 @@ sudo_mkdir_parents_v1(const char *path, uid_t uid, gid_t gid, mode_t mode, bool
pathend = cp + strlen(cp); pathend = cp + strlen(cp);
for (cp = sudo_strsplit(cp, pathend, "/", &ep); cp != NULL && ep != NULL; for (cp = sudo_strsplit(cp, pathend, "/", &ep); cp != NULL && ep != NULL;
cp = sudo_strsplit(NULL, pathend, "/", &ep)) { cp = sudo_strsplit(NULL, pathend, "/", &ep)) {
char name[NAME_MAX + 1];
int dfd, len; int dfd, len;
sudo_debug_printf(SUDO_DEBUG_DEBUG|SUDO_DEBUG_LINENO, sudo_debug_printf(SUDO_DEBUG_DEBUG|SUDO_DEBUG_LINENO,