isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

No need to flush logs before commit point if we flush after each write.

Browse Source 
Also document that logs are flushed before sending a commit point
even when flushing is disabled.
This commit is contained in:
Todd C. Miller
2021-10-16 07:58:44 -06:00
parent a554629d84
commit 15b4427b9a
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
doc/sudo_logsrvd.conf.man.in
View File

@@ -16,7 +16,7 @@
.\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF .\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. .\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
.\" .\"
.TH "SUDO_LOGSRVD.CONF" "@mansectform@" "August 3, 2021" "Sudo @PACKAGE_VERSION@" "File Formats Manual" .TH "SUDO_LOGSRVD.CONF" "@mansectform@" "October 16, 2021" "Sudo @PACKAGE_VERSION@" "File Formats Manual"
.nh .nh
.if n .ad l .if n .ad l
.SH "NAME" .SH "NAME"
@@ -550,6 +550,8 @@ buffering it.
This makes it possible to view the logs in real-time as the program is This makes it possible to view the logs in real-time as the program is
executing but may significantly reduce the effectiveness executing but may significantly reduce the effectiveness
of I/O log compression. of I/O log compression.
I/O logs are always flushed before sending a commit point to the client
regardless of this setting.
The default value is The default value is
\fRtrue\fR. \fRtrue\fR.
.TP 10n .TP 10n

4
doc/sudo_logsrvd.conf.mdoc.in
View File

@@ -15,7 +15,7 @@
.\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF .\" ACTION OF CONTRACT, NEGLIGENCE OR OTHER TORTIOUS ACTION, ARISING OUT OF
.\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE. .\" OR IN CONNECTION WITH THE USE OR PERFORMANCE OF THIS SOFTWARE.
.\" .\"
.Dd August 3, 2021 .Dd October 16, 2021
.Dt SUDO_LOGSRVD.CONF @mansectform@ .Dt SUDO_LOGSRVD.CONF @mansectform@
.Os Sudo @PACKAGE_VERSION@ .Os Sudo @PACKAGE_VERSION@
.Sh NAME .Sh NAME
@@ -486,6 +486,8 @@ buffering it.
This makes it possible to view the logs in real-time as the program is This makes it possible to view the logs in real-time as the program is
executing but may significantly reduce the effectiveness executing but may significantly reduce the effectiveness
of I/O log compression. of I/O log compression.
I/O logs are always flushed before sending a commit point to the client
regardless of this setting.
The default value is The default value is
.Li true . .Li true .
.It iolog_group = name .It iolog_group = name

3
logsrvd/logsrvd.c
View File

@@ -1164,6 +1164,9 @@ server_commit_cb(int unused, int what, void *v)
commit_point.tv_nsec = closure->elapsed_time.tv_nsec; commit_point.tv_nsec = closure->elapsed_time.tv_nsec;
if (!schedule_commit_point(&commit_point, closure)) if (!schedule_commit_point(&commit_point, closure))
connection_close(closure); connection_close(closure);
/* Flush I/O logs before sending commit point if needed. */
if (!iolog_get_flush())
iolog_flush_all(closure); iolog_flush_all(closure);
debug_return; debug_return;