Fix off-by-one that could result in duplicate SUDO_INTERCEPT_FD vars.

This commit is contained in:
Todd C. Miller
2021-08-24 08:34:14 -06:00
parent df68f4c8d9
commit 1391813443

View File

@@ -101,9 +101,9 @@ sudo_preload_dso(char *envp[], const char *dso_file, int intercept_fd)
continue;
}
if (intercept_fd != -1 && strncmp(envp[env_len], "SUDO_INTERCEPT_FD=",
sizeof("SUDO_INTERCEPT_FD=")) == 0) {
sizeof("SUDO_INTERCEPT_FD=") - 1) == 0) {
if (intercept_idx == -1) {
const char *cp = envp[env_len] + sizeof("SUDO_INTERCEPT_FD=");
const char *cp = envp[env_len] + sizeof("SUDO_INTERCEPT_FD=") - 1;
const char *errstr;
int fd;