isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Make sudo pass -Wwrite-strings

Browse Source
This commit is contained in:
Todd C. Miller
2022-06-28 16:33:15 -06:00
parent b3a8cad346
commit 13672f28df
77 changed files with 590 additions and 640 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
plugins/sudoers/editor.c
View File

@@ -126,7 +126,7 @@ copy_arg(const char *src, size_t len)
* as well as the argument vector.
*/
static char *
resolve_editor(const char *ed, size_t edlen, int nfiles, char **files,
resolve_editor(const char *ed, size_t edlen, int nfiles, char * const *files,
int *argc_out, char ***argv_out, char * const *allowlist)
{
char **nargv = NULL, *editor = NULL, *editor_path = NULL;
@@ -177,7 +177,7 @@ resolve_editor(const char *ed, size_t edlen, int nfiles, char **files,
goto oom;
}
if (nfiles != 0) {
nargv[nargc++] = "--";
nargv[nargc++] = (char *)"--";
while (nfiles--)
nargv[nargc++] = *files++;
}
@@ -211,10 +211,11 @@ oom:
* as well as the argument vector.
*/
char *
find_editor(int nfiles, char **files, int *argc_out, char ***argv_out,
find_editor(int nfiles, char * const *files, int *argc_out, char ***argv_out,
char * const *allowlist, const char **env_editor)
{
char *ev[3], *editor_path = NULL;
char *editor_path = NULL;
const char *ev[3];
unsigned int i;
debug_decl(find_editor, SUDOERS_DEBUG_UTIL);