isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Initialize digest_type to SUDO_DIGEST_INVALID, not -1 and make it unsigned.

Browse Source 
This makes the digest type consistently unsigned instead of a mix
of signed (for the -1 value in the tokenizer) and unsigned.
This commit is contained in:
Todd C. Miller
2023-06-03 08:59:14 -06:00
parent d633d82f22
commit 1278e36ff3
8 changed files with 17 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/sudoers/filedigest.c
View File

@@ -34,7 +34,8 @@
#include "sudo_digest.h"
unsigned char *
sudo_filedigest(int fd, const char *file, int digest_type, size_t *digest_len)
sudo_filedigest(int fd, const char *file, unsigned int digest_type,
size_t *digest_len)
{
unsigned char *file_digest = NULL;
unsigned char buf[32 * 1024];
@@ -46,7 +47,7 @@ sudo_filedigest(int fd, const char *file, int digest_type, size_t *digest_len)
*digest_len = sudo_digest_getlen(digest_type);
if (*digest_len == (size_t)-1) {
sudo_warnx(U_("unsupported digest type %d for %s"), digest_type, file);
sudo_warnx(U_("unsupported digest type %u for %s"), digest_type, file);
goto bad;
}