isa/sudo
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Add canon_path(), a realpath() wrapper that performs caching.

Browse Source 
This also adds a new user_cmnd_dir variable that stores the
canonicalized parent directory of the command to be run.
This commit is contained in:
Todd C. Miller
2023-02-21 13:24:33 -07:00
parent 0443d14578
commit 0ef5373678
5 changed files with 250 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
plugins/sudoers/sudoers.c
View File

@@ -1007,6 +1007,8 @@ set_cmnd_path(const char *runchroot)
list_cmnd = NULL;
free(user_cmnd);
user_cmnd = NULL;
canon_path_free(user_cmnd_dir);
user_cmnd_dir = NULL;
if (def_secure_path && !user_is_exempt())
path = def_secure_path;
@@ -1031,6 +1033,17 @@ set_cmnd_path(const char *runchroot)
goto error;
}
if (cmnd_out != NULL) {
char *slash = strrchr(cmnd_out, '/');
if (slash != NULL) {
*slash = '\0';
user_cmnd_dir = canon_path(cmnd_out);
if (user_cmnd_dir == NULL && errno == ENOMEM)
goto error;
*slash = '/';
}
}
if (ISSET(sudo_mode, MODE_CHECK))
list_cmnd = cmnd_out;
else
@@ -1849,6 +1862,7 @@ sudoers_cleanup(void)
sudo_user_free();
sudo_freepwcache();
sudo_freegrcache();
canon_path_free_cache();
/* Clear globals */
list_pw = NULL;
@@ -1908,6 +1922,7 @@ sudo_user_free(void)
free(user_srunhost);
free(user_runhost);
free(user_cmnd);
canon_path_free(user_cmnd_dir);
free(user_args);
free(list_cmnd);
free(safe_cmnd);