mirror of
https://github.com/brl/mutter.git
synced 2024-12-24 12:02:04 +00:00
df21e20f65
Although we use GLib internally in Cogl we would rather not leak GLib api through Cogl's own api, except through explicitly namespaced cogl_glib_ / cogl_gtype_ feature apis. One of the benefits we see to not leaking GLib through Cogl's public API is that documentation for Cogl won't need to first introduce the Glib API to newcomers, thus hopefully lowering the barrier to learning Cogl. This patch provides a Cogl specific typedef for reporting runtime errors which by no coincidence matches the typedef for GError exactly. If Cogl is built with --enable-glib (default) then developers can even safely assume that a CoglError is a GError under the hood. This patch also enforces a consistent policy for when NULL is passed as an error argument and an error is thrown. In this case we log the error and abort the application, instead of silently ignoring it. In common cases where nothing has been implemented to handle a particular error and/or where applications are just printing the error and aborting themselves then this saves some typing. This also seems more consistent with language based exceptions which usually cause a program to abort if they are not explicitly caught (which passing a non-NULL error signifies in this case) Since this policy for NULL error pointers is stricter than the standard GError convention, there is a clear note in the documentation to warn developers that are used to using the GError api. Reviewed-by: Neil Roberts <neil@linux.intel.com> (cherry picked from commit b068d5ea09ab32c37e8c965fc8582c85d1b2db46) Note: Since we can't change the Cogl 1.x api the patch was changed to not rename _error_quark() functions to be _error_domain() functions and although it's a bit ugly, instead of providing our own CoglError type that's compatible with GError we simply #define CoglError to GError unless Cogl is built with glib disabled. Note: this patch does technically introduce an API break since it drops the cogl_error_get_type() symbol generated by glib-mkenum (Since the CoglError enum was replaced by a CoglSystemError enum) but for now we are assuming that this will not affect anyone currently using the Cogl API. If this does turn out to be a problem in practice then we would be able to fix this my manually copying an implementation of cogl_error_get_type() generated by glib-mkenum into a compatibility source file and we could also define the original COGL_ERROR_ enums for compatibility too. Note: another minor concern with cherry-picking this patch to the 1.14 branch is that an api scanner would be lead to believe that some APIs have changed, and for example the gobject-introspection parser which understands the semantics of GError will not understand the semantics of CoglError. We expect most people that have tried to use gobject-introspection with Cogl already understand though that it is not well suited to generating bindings of the Cogl api anyway and we aren't aware or anyone depending on such bindings for apis involving GErrors. (GnomeShell only makes very-very minimal use of Cogl via the gjs bindings for the cogl_rectangle and cogl_color apis.) The main reason we have cherry-picked this patch to the 1.14 branch even given the above concerns is that without it it would become very awkward for us to cherry-pick other beneficial patches from master.
176 lines
5.7 KiB
C
176 lines
5.7 KiB
C
/*
|
|
* Cogl
|
|
*
|
|
* An object oriented GL/GLES Abstraction/Utility Layer
|
|
*
|
|
* Copyright (C) 2012 Intel Corporation.
|
|
*
|
|
* This library is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU Lesser General Public
|
|
* License as published by the Free Software Foundation; either
|
|
* version 2 of the License, or (at your option) any later version.
|
|
*
|
|
* This library is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* Lesser General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU Lesser General Public
|
|
* License along with this library; if not, write to the
|
|
* Free Software Foundation, Inc., 59 Temple Place - Suite 330,
|
|
* Boston, MA 02111-1307, USA.
|
|
*/
|
|
|
|
#if !defined(__COGL_H_INSIDE__) && !defined(COGL_COMPILATION)
|
|
#error "Only <cogl/cogl.h> can be included directly."
|
|
#endif
|
|
|
|
#ifndef __COGL_ERROR_H__
|
|
#define __COGL_ERROR_H__
|
|
|
|
#include "cogl-types.h"
|
|
|
|
/**
|
|
* SECTION:cogl-error
|
|
* @short_description: A way for Cogl to throw exceptions
|
|
*
|
|
* As a general rule Cogl shields non-recoverable errors from
|
|
* developers, such as most heap allocation failures (unless for
|
|
* exceptionally large resources which we might reasonably expect to
|
|
* fail) and this reduces the burdon on developers.
|
|
*
|
|
* There are some Cogl apis though that can fail for exceptional
|
|
* reasons that can also potentially be recovered from at runtime
|
|
* and for these apis we use a standard convention for reporting
|
|
* runtime recoverable errors.
|
|
*
|
|
* As an example if we look at the cogl_context_new() api which
|
|
* takes an error argument:
|
|
* |[
|
|
* CoglContext *
|
|
* cogl_context_new (CoglDisplay *display, CoglError **error);
|
|
* ]|
|
|
*
|
|
* A caller interested in catching any runtime error when creating a
|
|
* new #CoglContext would pass the address of a #CoglError pointer
|
|
* that has first been initialized to %NULL as follows:
|
|
*
|
|
* |[
|
|
* CoglError *error = NULL;
|
|
* CoglContext *context;
|
|
*
|
|
* context = cogl_context_new (NULL, &error);
|
|
* ]|
|
|
*
|
|
* The return status should usually be enough to determine if there
|
|
* was an error set (in this example we can check if context == %NULL)
|
|
* but if it's not possible to tell from the function's return status
|
|
* you can instead look directly at the error pointer which you
|
|
* initialized to %NULL. In this example we now check the error,
|
|
* report any error to the user, free the error and then simply
|
|
* abort without attempting to recover.
|
|
*
|
|
* |[
|
|
* if (context == NULL)
|
|
* {
|
|
* fprintf (stderr, "Failed to create a Cogl context: %s\n",
|
|
* error->message);
|
|
* cogl_error_free (error);
|
|
* abort ();
|
|
* }
|
|
* ]|
|
|
*
|
|
* All Cogl APIs that accept an error argument can also be passed a
|
|
* %NULL pointer. In this case if an exceptional error condition is hit
|
|
* then Cogl will simply log the error message and abort the
|
|
* application. This can be compared to language execeptions where the
|
|
* developer has not attempted to catch the exception. This means the
|
|
* above example is essentially redundant because it's what Cogl would
|
|
* have done automatically and so, similarly, if your application has
|
|
* no way to recover from a particular error you might just as well
|
|
* pass a %NULL #CoglError pointer to save a bit of typing.
|
|
*
|
|
* <note>If you are used to using the GLib API you will probably
|
|
* recognize that #CoglError is just like a #GError. In fact if Cogl
|
|
* has been built with --enable-glib then it is safe to cast a
|
|
* #CoglError to a #GError.</note>
|
|
*
|
|
* <note>An important detail to be aware of if you are used to using
|
|
* GLib's GError API is that Cogl deviates from the GLib GError
|
|
* conventions in one noteable way which is that a %NULL error pointer
|
|
* does not mean you want to ignore the details of an error, it means
|
|
* you are not trying to catch any exceptional errors the function might
|
|
* throw which will result in the program aborting with a log message
|
|
* if an error is thrown.</note>
|
|
*/
|
|
|
|
#ifdef COGL_HAS_GLIB_SUPPORT
|
|
#define CoglError GError
|
|
#else
|
|
/**
|
|
* CoglError:
|
|
* @domain: A high-level domain identifier for the error
|
|
* @code: A specific error code within a specified domain
|
|
* @message: A human readable error message
|
|
*/
|
|
typedef struct _CoglError
|
|
{
|
|
uint32_t domain;
|
|
int code;
|
|
char *message;
|
|
} CoglError;
|
|
#endif /* COGL_HAS_GLIB_SUPPORT */
|
|
|
|
/**
|
|
* cogl_error_free:
|
|
* @error: A #CoglError thrown by the Cogl api
|
|
*
|
|
* Frees a #CoglError and associated resources.
|
|
*/
|
|
void
|
|
cogl_error_free (CoglError *error);
|
|
|
|
/**
|
|
* cogl_error_copy:
|
|
* @error: A #CoglError thrown by the Cogl api
|
|
*
|
|
* Makes a copy of @error which can later be freed using
|
|
* cogl_error_free().
|
|
*
|
|
* Return value: A newly allocated #CoglError initialized to match the
|
|
* contents of @error.
|
|
*/
|
|
CoglError *
|
|
cogl_error_copy (CoglError *error);
|
|
|
|
/**
|
|
* cogl_error_matches:
|
|
* @error: A #CoglError thrown by the Cogl api or %NULL
|
|
*
|
|
* Returns %TRUE if error matches domain and code, %FALSE otherwise.
|
|
* In particular, when error is %NULL, FALSE will be returned.
|
|
*
|
|
* Return value: whether the @error corresponds to the given @domain
|
|
* and @code.
|
|
*/
|
|
CoglBool
|
|
cogl_error_matches (CoglError *error,
|
|
uint32_t domain,
|
|
int code);
|
|
|
|
/**
|
|
* COGL_GLIB_ERROR:
|
|
* @COGL_ERROR: A #CoglError thrown by the Cogl api or %NULL
|
|
*
|
|
* Simply casts a #CoglError to a #CoglError
|
|
*
|
|
* If Cogl is built with GLib support then it can safely be assumed
|
|
* that a CoglError is a GError and can be used directly with the
|
|
* GError api.
|
|
*/
|
|
#ifdef COGL_HAS_GLIB_SUPPORT
|
|
#define COGL_GLIB_ERROR(COGL_ERROR) ((CoglError *)COGL_ERROR)
|
|
#endif
|
|
|
|
#endif /* __COGL_ERROR_H__ */
|