edc226a04d
Having the stage device list be responsible for delivering the same events twice (first immediately to clients, then later to Clutter) was expected to be tricky, a sneaky problem with it right now is the following case: While collecting events for a stage update cycle, we get three touch events from the backend: TOUCH_BEGIN(seq=1) -> TOUCH_END(seq=1) -> TOUCH_BEGIN(seq=1) What we do right now when we see a TOUCH_BEGIN event is adding a device to the stage right when it comes in from the backend. And when we see a TOUCH_END, we remove the device from the stage not immediately but only after it went through the queue. In the case of the three events mentioned above, with the current behavior, this will happen when they come in from the backend: - TOUCH_BEGIN(seq=1): device gets added to the stage with seq 1, event gets queued - TOUCH_END(seq=1): Nothing happens, event gets queued - TOUCH_BEGIN(seq=1): we try to add device to the stage, but seq 1 is already there, event gets queued Now when we go through the queue and see the TOUCH_END, the device with seq 1 gets removed, but on the subsequent TOUCH_BEGIN, we won't add a new device, so this event (and all events with seq=1 that are still in the queue) is now ignored by Clutter because it has no device. What we want to do here is to cut short once the TOUCH_END event comes in: Process queued events immediately and make sure the device is removed from the stage list before a new device can be added. Same goes for any other events that will lead to devices getting removed. Small note: Since this leads to clutter_stage_get_device_actor() returning NULL, I was wondering why we never crash because of this: Turns out _clutter_actor_handle_event() handles self = NULL just fine without crashing... Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2696> |
||
|---|---|---|
| .gitlab/issue_templates | ||
| .gitlab-ci | ||
| clutter | ||
| cogl | ||
| data | ||
| doc | ||
| meson | ||
| po | ||
| src | ||
| subprojects | ||
| tools | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| check-style.py | ||
| config.h.meson | ||
| COPYING | ||
| HACKING.md | ||
| meson_options.txt | ||
| meson.build | ||
| mutter.doap | ||
| NEWS | ||
| README.md | ||
Mutter
Mutter is a Wayland display server and X11 window manager and compositor library.
When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.
When used on top of Xorg it acts as a X11 window manager and compositing manager.
It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.
Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork of Clutter, a scene graph and user interface toolkit.
Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.
It can be useful to look at the documentation available at the Wiki.
The API documentation is available at:
- Meta: https://gnome.pages.gitlab.gnome.org/mutter/meta/
- Clutter: https://gnome.pages.gitlab.gnome.org/mutter/clutter/
- Cally: https://gnome.pages.gitlab.gnome.org/mutter/cally/
- Cogl: https://gnome.pages.gitlab.gnome.org/mutter/cogl/
- CoglPango: https://gnome.pages.gitlab.gnome.org/mutter/cogl-pango/
Coding style and conventions
See HACKING.md.
Git messages
Commit messages should follow the GNOME commit message
guidelines. We require an URL
to either an issue or a merge request in each commit. Try to always prefix
commit subjects with a relevant topic, such as compositor: or
clutter/actor:, and it's always better to write too much in the commit
message body than too little.
Default branch
The default development branch is main. If you still have a local
checkout under the old name, use:
git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main
License
Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.