e5347af000
Currently, mutter checks for the presence of X11 windows to decide whether or not Xwayland can be terminated, when Xwayland is started on demand. Unfortunately, not all X11 clients will map a window all the time, an X11 client may keep the X11 connection opened after closing all its windows. In that case, we may terminate Xwayland while there are some X11 client connected still, and terminating Xwayland will also kill those X11 clients. To avoid that issue, check the X11 clients actually connected using the XRes extension. The XRes extension provides the PID of the (local) X11 clients connected to the Xserver, so we need to match that against the actual executable names, and compare with a list of known executables that we can safely ignore, such as ibus-x11 or gsd-xsettings. We also check against our own executable name, considering that the X11 window manager is also an X11 client connected to the Xserver. Also, XRes returning the PID of local clients only is not a problem considering that Xwayland does not listen to remote connections. However, if the user spawns a client remotely on another system using ssh tunneling (ssh -X), only clients which actually map a window will be accounted for. Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/1537 Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1671> |
||
---|---|---|
.gitlab/issue_templates | ||
.gitlab-ci | ||
clutter | ||
cogl | ||
data | ||
doc | ||
meson | ||
po | ||
src | ||
subprojects | ||
tools | ||
.gitignore | ||
.gitlab-ci.yml | ||
config.h.meson | ||
COPYING | ||
meson_options.txt | ||
meson.build | ||
mutter.doap | ||
NEWS | ||
README.md |
Mutter
Mutter is a Wayland display server and X11 window manager and compositor library.
When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.
When used on top of Xorg it acts as a X11 window manager and compositing manager.
It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.
Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.
Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.
It can be useful to look at the documentation available at the Wiki.
Coding style and conventions
The coding style used is primarily the GNU flavor of the GNOME coding style with some additions:
-
Use regular C types and
stdint.h
types instead of GLib fundamental types, except forgboolean
, andguint
/gulong
for GSource ids and signal handler ids. That means e.g.uint64_t
instead ofguint64
,int
instead ofgint
,unsigned int
instead ofguint
if unsignedness is of importance,uint8_t
instead ofguchar
, and so on. -
Try to to limit line length to 80 characters, although it's not a strict limit.
-
Usage of g_autofree and g_autoptr are encouraged. The style used is
g_autofree char *text = NULL;
g_autoptr (MetaSomeThing) thing = NULL;
text = g_strdup_printf ("The text: %d", a_number);
thing = g_object_new (META_TYPE_SOME_THING,
"text", text,
NULL);
thinger_use_thing (rocket, thing);
-
Declare variables at the top of the block they are used, but avoid non-trivial logic among variable declarations. Non-trivial logic can be getting a pointer that may be
NULL
, any kind of math, or anything that may have side effects. -
Instead of boolean arguments in functions, prefer enums or flags when they're more expressive.
-
Use
g_new0()
etc instead ofg_slice_new0()
. -
Initialize and assign floating point variables (i.e.
float
ordouble
) using the formfloating_point = 3.14159
orratio = 2.0
.
Git messages
Commit messages should follow the GNOME commit message
guidelines. We require an URL
to either an issue or a merge request in each commit. Try to always prefix
commit subjects with a relevant topic, such as compositor:
or
clutter/actor:
, and it's always better to write too much in the commit
message body than too little.
License
Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.