mirror of
https://github.com/brl/mutter.git
synced 2024-12-24 12:02:04 +00:00
185630085c
This option to GCC makes it give a warning whenever a global function is defined without a declaration. This should catch cases were we've defined a function but forgot to put it in a header. In that case it is either only used within one file so we should make it static or we should declare it in a header. The following changes where made to fix problems: • Some functions were made static • cogl-path.h (the one containing the 1.0 API) was split into two files, one defining the functions and one defining the enums so that cogl-path.c can include the enum and function declarations from the 2.0 API as well as the function declarations from the 1.0 API. • cogl2-clip-state has been removed. This only had one experimental function called cogl_clip_push_from_path but as this is unstable we might as well remove it favour of the equivalent cogl_framebuffer_* API. • The GLX, SDL and WGL winsys's now have a private header to define their get_vtable function instead of directly declaring in the C file where it is called. • All places that were calling COGL_OBJECT_DEFINE need to have the cogl_is_whatever function declared so these have been added either as a public function or in a private header. • Some files that were not including the header containing their function declarations have been fixed to do so. • Any unused error quark functions have been removed. If we later want them we should add them back one by one and add a declaration for them in a header. • _cogl_is_framebuffer has been renamed to cogl_is_framebuffer and made a public function with a declaration in cogl-framebuffer.h • Similarly for CoglOnscreen. • cogl_vdraw_indexed_attributes is called cogl_framebuffer_vdraw_indexed_attributes in the header. The definition has been changed to match the header. • cogl_index_buffer_allocate has been removed. This had no declaration and I'm not sure what it's supposed to do. • CoglJournal has been changed to use the internal CoglObject macro so that it won't define an exported cogl_is_journal symbol. • The _cogl_blah_pointer_from_handle functions have been removed. CoglHandle isn't used much anymore anyway and in the few places where it is used I think it's safe to just use the implicit cast from void* to the right type. • The test-utils.h header for the conformance tests explicitly disables the -Wmissing-declaration option using a pragma because all of the tests declare their main function without a header. Any mistakes relating to missing declarations aren't really important for the tests. • cogl_quaternion_init_from_quaternion and init_from_matrix have been given declarations in cogl-quaternion.h Reviewed-by: Robert Bragg <robert@linux.intel.com> |
||
|---|---|---|
| .. | ||
| cogl-texture-pixmap-x11-private.h | ||
| cogl-texture-pixmap-x11.c | ||
| cogl-texture-pixmap-x11.h | ||
| cogl-winsys-egl-android-private.h | ||
| cogl-winsys-egl-android.c | ||
| cogl-winsys-egl-feature-functions.h | ||
| cogl-winsys-egl-gdl-private.h | ||
| cogl-winsys-egl-gdl.c | ||
| cogl-winsys-egl-kms-private.h | ||
| cogl-winsys-egl-kms.c | ||
| cogl-winsys-egl-null-private.h | ||
| cogl-winsys-egl-null.c | ||
| cogl-winsys-egl-private.h | ||
| cogl-winsys-egl-wayland-private.h | ||
| cogl-winsys-egl-wayland.c | ||
| cogl-winsys-egl-x11-private.h | ||
| cogl-winsys-egl-x11.c | ||
| cogl-winsys-egl.c | ||
| cogl-winsys-glx-feature-functions.h | ||
| cogl-winsys-glx-private.h | ||
| cogl-winsys-glx.c | ||
| cogl-winsys-private.h | ||
| cogl-winsys-sdl-private.h | ||
| cogl-winsys-sdl.c | ||
| cogl-winsys-stub-private.h | ||
| cogl-winsys-stub.c | ||
| cogl-winsys-wgl-feature-functions.h | ||
| cogl-winsys-wgl-private.h | ||
| cogl-winsys-wgl.c | ||
| cogl-winsys.c | ||