Go to file
Jonas Ådahl ce3409b2b7 kms-impl-simple: Handle mode set race conditions gracefully
If we end up trying to do a mode set on a DRM state that has already
changed behind our back without us yet having seen the hotplug event we
may fail with `EINVAL`. Since the renderer layer doesn't handle mode set
failure, it'll still try to page flip later on, which will then also
fail. When failing, it'll try to look up the cached mode set in order to
retry the mode set later on, as is needed to handle other error
conditions. However, if the mode set prior to the page flip failed, we
won't cache the mode set, and the page flip error handling code will get
confused.

Instead of asserting that a page flip always has a valid cached mode set
ready to look up, handle it being missing more gracefully by failing to
mode set. It is expected that things will correct themself as there
should be a hotplug event waiting around the the corner, to reconfigure
the monitor configuration setting new modes.

Fixes: https://gitlab.gnome.org/GNOME/mutter/issues/917

https://gitlab.gnome.org/GNOME/mutter/merge_requests/1007
2020-01-16 14:50:34 +00:00
.gitlab/issue_templates gitlab: Add issue templates 2020-01-08 19:34:19 +00:00
.gitlab-ci ci: Change instructions to use podman 2019-12-11 12:56:28 +01:00
clutter Use G_GNUC_FALLTHROUGH instead of comments 2020-01-09 17:58:29 +01:00
cogl Use G_GNUC_FALLTHROUGH instead of comments 2020-01-09 17:58:29 +01:00
data wayland: Add setting/api to check the policy to set up the X11 display 2019-08-06 00:41:36 +00:00
doc Remove obsolete .cvsignore files 2019-01-10 11:50:54 -02:00
meson build: Add postinstall script 2019-08-27 09:57:54 +00:00
po Update Chinese (China) translation 2019-12-27 08:15:48 +00:00
src kms-impl-simple: Handle mode set race conditions gracefully 2020-01-16 14:50:34 +00:00
tools tools: Remove obsolete ppa-magic.py 2018-11-30 11:12:12 +08:00
.gitignore project: Update gitignore 2019-01-10 11:50:54 -02:00
.gitlab-ci.yml ci: Update docker image to v3 2019-10-29 02:11:02 +01:00
config.h.meson main: Make process PR_SET_DUMPABLE 2019-09-27 14:27:09 +00:00
COPYING Updated obsolete FSF postal address in COPYING 2014-01-12 08:44:30 +07:00
meson_options.txt cogl: Add libsysprof capture based tracing 2019-05-31 11:55:56 -03:00
meson.build tests/wayland: Test subsurface commits after parent was reset 2020-01-10 16:01:22 +00:00
mutter.doap doap: Update list of maintainers 2019-10-16 12:33:47 +02:00
NEWS Bump version to 3.35.3 2020-01-05 12:15:29 +01:00
README.md README: Add contribution section 2019-02-14 15:38:46 +01:00

Mutter

Mutter is a Wayland display server and X11 window manager and compositor library.

When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.

When used on top of Xorg it acts as a X11 window manager and compositing manager.

It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.

Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.

Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.

The coding style used is primarily the GNU flavor of the GNOME coding style with some minor additions such as preferring stdint.h types over GLib fundamental types, and a soft 80 character line limit. However, in general, look at the file you're editing for inspiration.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

License

Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.