Go to file
Sebastian Keller c86d8a23c3 clutter/actor: Don't write uninitialized out values on failed transform
clutter_actor_get_transformed_position() would write the uninitialized
values of v2 when clutter_actor_apply_transform_to_point() fails in
_clutter_actor_fully_transform_vertices() because the actor has not been
added to the stage yet.

When called from JS this would overwrite the zero initialized values
passed in from gjs. If the uninitialized values now happen to correspond
to one of the NaN float values used by mozjs to represent a pointer
type, this would lead to seemingly random crashes in mozjs code later
on.

Avoid this by using _clutter_actor_fully_transform_vertices() directly,
which allows us to check if it failed.

Related: https://gitlab.gnome.org/GNOME/gnome-shell-extensions/-/issues/469
Related: https://gitlab.gnome.org/GNOME/gjs/-/issues/591
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3453>
2023-12-15 15:08:22 +00:00
.gitlab/issue_templates gitlab: Add missing < in markdown comment tag 2020-02-14 03:10:28 +00:00
.gitlab-ci ci: Look for matching ref in user remote for branch pipeline 2023-08-08 04:11:13 +02:00
clutter clutter/actor: Don't write uninitialized out values on failed transform 2023-12-15 15:08:22 +00:00
cogl cogl: Remove unused Buffer:usage-hint 2023-12-13 11:20:04 +00:00
data Add debug controller 2023-12-01 14:25:08 +00:00
doc cogl/gir: Depend explicitly on Mtk 2023-11-03 11:27:52 +00:00
meson build: Replace custom post-install script 2022-11-19 02:21:05 +01:00
mtk cleanup: Stop allowing deprecated Cogl API usage 2023-11-15 13:13:00 +01:00
po Update Russian translation 2023-12-11 12:16:42 +00:00
src backends: Include unistd.h to fix compilation on musl 2023-12-15 14:59:26 +00:00
subprojects build: Update sysprof build options 2022-12-17 19:58:00 +00:00
tools Add debug controller 2023-12-01 14:25:08 +00:00
.gitignore Add .buildconfig to .gitignore 2023-02-17 21:44:29 +00:00
.gitlab-ci.yml ci: Mark our git clone as a safe directory 2023-12-13 11:09:32 +00:00
check-style.py ci: Mark the regex to find chunks in code style checks as regex string 2023-12-15 14:49:57 +00:00
config.h.meson build: One config file to rule them all 2023-11-15 12:00:19 +00:00
COPYING Updated obsolete FSF postal address in COPYING 2014-01-12 08:44:30 +07:00
HACKING.md Document trace span naming 2023-11-22 11:46:07 +00:00
meson_options.txt edid: Integrate libdisplay-info for edid parsing 2023-05-02 17:37:01 +00:00
meson.build cogl: Stop auto generating gl/egl headers 2023-11-17 11:24:23 +00:00
mutter.doap DOAP: Remove defunct mailing list; add Discourse 2023-09-15 03:19:22 +02:00
NEWS Bump version to 45.0 2023-09-16 22:51:03 +02:00
README.md readme: Add Mtk docs link 2023-09-02 10:50:47 +00:00

Mutter

Mutter is a Wayland display server and X11 window manager and compositor library.

When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.

When used on top of Xorg it acts as a X11 window manager and compositing manager.

It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.

Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork of Clutter, a scene graph and user interface toolkit.

Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.

It can be useful to look at the documentation available at the Wiki.

The API documentation is available at:

Coding style and conventions

See HACKING.md.

Git messages

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit. Try to always prefix commit subjects with a relevant topic, such as compositor: or clutter/actor:, and it's always better to write too much in the commit message body than too little.

If a commit fixes an issue and that issue should be closed, add URL to it in the bottom of the commit message and prefix with Closes:.

Do not add any Part-of: line, as that will be handled automatically when merging.

The Fixes tag

If a commit fixes a regression caused by a particular commit, it can be marked with the Fixes: tag. To produce such a tag, use

git show -s --pretty='format:Fixes: %h (\"%s\")' <COMMIT>

or create an alias

git config --global alias.fixes "show -s --pretty='format:Fixes: %h (\"%s\")'"

and then use

git fixes <COMMIT>

Example

compositor: Also consider dark matter when calculating paint volume

Ignoring dark matter when calculating the paint volume missed the case where
compositing happens in complete vacuum.

Fixes: 123abc123ab ("compositor: Calculate paint volume ourselves")
Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/1234

Default branch

The default development branch is main. If you still have a local checkout under the old name, use:

git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main

License

Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.