mirror of
https://github.com/brl/mutter.git
synced 2024-11-23 00:20:42 -05:00
9691827b5b
The load-finished signal has a GError* argument which is meant to signify whether the loading was successful. However many of the places in ClutterTexture that emit this signal directly pass their 'error' variable which is a GError** and will be NULL or not completely independently of whether there was an error. If the argument was dereferenced it would probably crash. The test-texture-async interactive test case should also verify that the ::load-finished signal is correctly emitted. Fixes bug: http://bugzilla.openedhand.com/show_bug.cgi?id=1622 |
||
|---|---|---|
| .. | ||
| conform | ||
| data | ||
| interactive | ||
| micro-bench | ||
| tools | ||
| .gitignore | ||
| Makefile.am | ||
| README | ||
Outline of test categories: The conform/ tests should be non-interactive unit-tests that verify a single feature is behaving as documented. See conform/ADDING_NEW_TESTS for more details. The micro-bench/ tests should be focused perfomance test, ideally testing a single metric. Please never forget that these tests are synthetec and if you are using them then you understand what metric is being tested. They probably don't reflect any real world application loads and the intention is that you use these tests once you have already determined the crux of your problem and need focused feedback that your changes are indeed improving matters. There is no exit status requirements for these tests, but they should give clear feedback as to their performance. If the framerate is the feedback metric, then the test should forcibly enable FPS debugging. The interactive/ tests are any tests whos status can not be determined without a user looking at some visual output, or providing some manual input etc. This covers most of the original Clutter tests. Ideally some of these tests will be migrated into the conformance/ directory so they can be used in automated nightly tests. Other notes: All tests should ideally include a detailed description in the source explaining exactly what the test is for, how the test was designed to work, and possibly a rationale for the aproach taken for testing.