mirror of
https://github.com/brl/mutter.git
synced 2024-11-26 01:50:42 -05:00
488639eb63
Due to the way add_device() invariably adds to the master/slave device lists, while keeping ClutterInputDevices 1:1 with device IDs, it may leave invalid pointers in the list if add_device() is called multiple times for the same device ID. There are two situations where this may happen: 1) If devices are disabled and later enabled: devices are added invariably to the master/slave lists on constructed(), but then on XIDeviceEnabled they'd get added yet again. 2) Racy cases where the ClutterDeviceManager is created around the same time XIHierarchyEvents are sent. When getting the XIDeviceInfo on constructed(), these devices may already appear as enabled, even though XIDeviceEnabled is seen through XIHierarchyEvents processed in the event loop sortly after. This last case can be seen when starting gnome-shell on a different tty, and entering in the one it's been spawned on, clutter initialization happens around the same time devices are added back because of the tty switch, and multiple extra ClutterInputDevices are created. https://bugzilla.gnome.org/show_bug.cgi?id=724971 |
||
|---|---|---|
| .. | ||
| xsettings | ||
| clutter-backend-x11.c | ||
| clutter-backend-x11.h | ||
| clutter-device-manager-core-x11.c | ||
| clutter-device-manager-core-x11.h | ||
| clutter-device-manager-xi2.c | ||
| clutter-device-manager-xi2.h | ||
| clutter-event-x11.c | ||
| clutter-glx-texture-pixmap.c | ||
| clutter-glx-texture-pixmap.h | ||
| clutter-glx.h | ||
| clutter-input-device-core-x11.c | ||
| clutter-input-device-core-x11.h | ||
| clutter-input-device-xi2.c | ||
| clutter-input-device-xi2.h | ||
| clutter-keymap-x11.c | ||
| clutter-keymap-x11.h | ||
| clutter-settings-x11.h | ||
| clutter-stage-x11.c | ||
| clutter-stage-x11.h | ||
| clutter-x11-texture-pixmap.c | ||
| clutter-x11-texture-pixmap.h | ||
| clutter-x11.h | ||