mirror of
https://github.com/brl/mutter.git
synced 2024-11-24 00:50:42 -05:00
32c99513c8
When calculating the resource scale of a clone source, we might end up in situations where we fail to do so, even though we're in a paint. A real world example when this may happen if this happens: * A client creates a toplevel window * A client creates a modal dialog for said toplevel window * Said client commits a buffer to the modal before the toplevel If GNOME Shell is in overview mode, the window group is hidden, and the toplevel window actor is hidden. When the clone tries to paint, it fails to calculate the resource scale, as the parent of the parent (window group) is not currently mapped. It would have succeeded if only the clone source was unmapped, as it deals with the unmapped actor painting by setting intermediate state while painting, but this does not work when the *parent* of the source is unmapped as well. Fix this by inheriting the unmapped clone paint even when calculating the resource scale. This also adds a test case that mimics the sequence of events otherwise triggered by a client. We can't add a Wayland client to test this, where we actually crash is in the offscreen redirect effect used by the window dimming feature in GNOME Shell. Fixes: https://gitlab.gnome.org/GNOME/mutter/-/issues/808 https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1147 |
||
|---|---|---|
| .. | ||
| accessibility | ||
| conform | ||
| interactive | ||
| micro-bench | ||
| performance | ||
| clutter-1.0.suppressions | ||
| meson.build | ||
| README | ||
| test-utils.h | ||
Outline of test categories:
The conform/ tests should be non-interactive unit-tests that verify a single
feature is behaving as documented. Use the GLib and Clutter test API and macros
to write the test units. The conformance test suites are meant to be used with
continuous integration builds.
The performance/ tests are performance tests, both focused tests testing single
metrics and larger tests. These tests are used to report one or more
performance markers for the build of Clutter. Each performance marker is picked
up from the standard output of running the tests from strings having the form
"\n@ marker-name: 42.23" where 'marker-name' and '42.23' are the key/value pairs
of a single metric. Each test can provide multiple key/value pairs. Note that
if framerate is the feedback metric the test should forcibly enable FPS
debugging itself. The file test-common.h contains utility function helping to
do fps reporting.
The interactive/ tests are any tests whose status can not be determined without
a user looking at some visual output, or providing some manual input etc. This
covers most of the original Clutter tests. Ideally some of these tests will be
migrated into the conform/ directory.
The accessibility/ tests are tests created to test the accessibility support of
clutter, testing some of the atk interfaces.
Other notes:
• All tests should ideally include a detailed description in the source
explaining exactly what the test is for, how the test was designed to work,
and possibly a rationale for the approach taken for testing. Tests for specific
bugs should reference the bug report URL or number.
• When running tests under Valgrind, you should follow the instructions
available here:
https://wiki.gnome.org/Valgrind
and also use the suppression file available in the Git repository.