Go to file
Sebastian Keller 81deb99435 clutter/stage: Make paint_to_buffer use the correct texture/buffer size
The size of the buffer the texture will be written to by
paint_to_buffer() is determined based on
meta_screen_cast_area_stream_src_get_specs() which uses roundf() to
calculate the width and height after scaling. Because the size of the
texture to be written to that buffer is calculated using ceilf(), it
might exceed the allocated buffer when using fractional scaling.

In 3.36 paint_to_buffer() is used from capture_view() which also uses
roundf() to allocate its buffer. Here this leads to a memory corruption
resulting in a crash when taking screenshots of an area.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/2842

https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1320


(cherry picked from commit e216d9c6ad)
2020-06-17 19:36:46 +00:00
.gitlab/issue_templates gitlab: Add missing < in markdown comment tag 2020-02-14 03:10:28 +00:00
.gitlab-ci ci: Adjust URL check 2020-02-26 06:28:46 +00:00
clutter clutter/stage: Make paint_to_buffer use the correct texture/buffer size 2020-06-17 19:36:46 +00:00
cogl cogl: Defend against empty or unallocated framebuffers 2020-04-03 13:49:34 +02:00
data display: Make check-alive timeout configureable 2020-02-23 17:28:57 +00:00
doc Add MetaGravity and replace X11 equivalent with it 2020-02-29 21:01:50 +00:00
meson build: Add postinstall script 2019-08-27 09:57:54 +00:00
po Update German translation 2020-04-24 22:37:32 +00:00
src window-actor-x11: switch the signal callback argument and data on shadow factory change 2020-06-16 16:04:38 +00:00
tools tools: Remove obsolete ppa-magic.py 2018-11-30 11:12:12 +08:00
.gitignore project: Update gitignore 2019-01-10 11:50:54 -02:00
.gitlab-ci.yml ci: Add a new 'build-without-opengl-and-glx' step 2020-03-26 18:24:54 -03:00
config.h.meson wayland: Set up initialization X11 socket 2020-02-29 20:41:26 +00:00
COPYING Updated obsolete FSF postal address in COPYING 2014-01-12 08:44:30 +07:00
meson_options.txt meson: Expand on xwayland_initfd option description 2020-03-09 17:59:25 +00:00
meson.build Bump version to 3.36.3 2020-06-03 01:35:15 +02:00
mutter.doap doap: Update list of maintainers 2019-10-16 12:33:47 +02:00
NEWS Bump version to 3.36.3 2020-06-03 01:35:15 +02:00
README.md README: Add contribution section 2019-02-14 15:38:46 +01:00

Mutter

Mutter is a Wayland display server and X11 window manager and compositor library.

When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.

When used on top of Xorg it acts as a X11 window manager and compositing manager.

It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.

Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.

Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.

The coding style used is primarily the GNU flavor of the GNOME coding style with some minor additions such as preferring stdint.h types over GLib fundamental types, and a soft 80 character line limit. However, in general, look at the file you're editing for inspiration.

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.

License

Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.