mutter/src/compositor/meta-compositor-x11.c
Daniel van Vugt f606a4424a compositor/x11: Sync again at the end of before_paint
The existing comment tells us this is necessary:

> there may be drawing between the last damage event and the
> XDamageSubtract() that needs to be flushed as well.

But the commit message for 551101c65cda also tells us that
synchronization is necessary before-update. Assuming both are correct
then it needs to be done in both places.

I did try optimizing out the second sync to only do it if damage
arrived during the update, but that doesn't seem to be the issue.
The damage event is arriving before the update starts and it's some
secondary changes within the damage region running late that need
flushing. So this means the client is reporting damage more frequently
than the frame rate and we're ignoring the secondary damage reports
for efficiency (XDamageReportBoundingBox), which is still a good thing.

Fixes: 551101c65cda ("compositor-x11: Move synchronization to before-update")
Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/2880
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/3590>
2024-02-20 18:22:00 +08:00

544 lines
18 KiB
C

/*
* Copyright (C) 2019 Red Hat Inc.
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, see <http://www.gnu.org/licenses/>.
*
*/
#include "config.h"
#include "compositor/meta-compositor-x11.h"
#include <X11/extensions/shape.h>
#include <X11/extensions/Xcomposite.h>
#include "backends/x11/meta-backend-x11.h"
#include "backends/x11/meta-clutter-backend-x11.h"
#include "backends/x11/meta-event-x11.h"
#include "compositor/meta-compositor-view.h"
#include "compositor/meta-sync-ring.h"
#include "compositor/meta-window-actor-x11.h"
#include "core/display-private.h"
#include "x11/meta-x11-display-private.h"
struct _MetaCompositorX11
{
MetaCompositor parent;
Window output;
gulong before_update_handler_id;
gulong after_update_handler_id;
gboolean frame_has_updated_xsurfaces;
gboolean have_x11_sync_object;
MetaWindow *unredirected_window;
gboolean xserver_uses_monotonic_clock;
int64_t xserver_time_query_time_us;
int64_t xserver_time_offset_us;
};
G_DEFINE_TYPE (MetaCompositorX11, meta_compositor_x11, META_TYPE_COMPOSITOR)
static void
process_damage (MetaCompositorX11 *compositor_x11,
XDamageNotifyEvent *damage_xevent,
MetaWindow *window)
{
MetaWindowActor *window_actor = meta_window_actor_from_window (window);
MetaWindowActorX11 *window_actor_x11 = META_WINDOW_ACTOR_X11 (window_actor);
meta_window_actor_x11_process_damage (window_actor_x11, damage_xevent);
compositor_x11->frame_has_updated_xsurfaces = TRUE;
}
void
meta_compositor_x11_process_xevent (MetaCompositorX11 *compositor_x11,
XEvent *xevent,
MetaWindow *window)
{
MetaCompositor *compositor = META_COMPOSITOR (compositor_x11);
MetaDisplay *display = meta_compositor_get_display (compositor);
MetaX11Display *x11_display = display->x11_display;
int damage_event_base;
damage_event_base = meta_x11_display_get_damage_event_base (x11_display);
if (xevent->type == damage_event_base + XDamageNotify)
{
/*
* Core code doesn't handle damage events, so we need to extract the
* MetaWindow ourselves.
*/
if (!window)
{
Window xwindow;
xwindow = ((XDamageNotifyEvent *) xevent)->drawable;
window = meta_x11_display_lookup_x_window (x11_display, xwindow);
}
if (window)
process_damage (compositor_x11, (XDamageNotifyEvent *) xevent, window);
}
if (compositor_x11->have_x11_sync_object)
meta_sync_ring_handle_event (xevent);
}
static void
determine_server_clock_source (MetaCompositorX11 *compositor_x11)
{
MetaCompositor *compositor = META_COMPOSITOR (compositor_x11);
MetaDisplay *display = meta_compositor_get_display (compositor);
MetaX11Display *x11_display = display->x11_display;
uint32_t server_time_ms;
int64_t server_time_us;
int64_t translated_monotonic_now_us;
server_time_ms = meta_x11_display_get_current_time_roundtrip (x11_display);
server_time_us = ms2us (server_time_ms);
translated_monotonic_now_us =
meta_translate_to_high_res_xserver_time (g_get_monotonic_time ());
/* If the server time offset is within a second of the monotonic time, we
* assume that they are identical. This seems like a big margin, but we want
* to be as robust as possible even if the system is under load and our
* processing of the server response is delayed.
*/
if (ABS (server_time_us - translated_monotonic_now_us) < s2us (1))
compositor_x11->xserver_uses_monotonic_clock = TRUE;
else
compositor_x11->xserver_uses_monotonic_clock = FALSE;
}
static gboolean
meta_compositor_x11_manage (MetaCompositor *compositor,
GError **error)
{
MetaCompositorX11 *compositor_x11 = META_COMPOSITOR_X11 (compositor);
MetaDisplay *display = meta_compositor_get_display (compositor);
MetaContext *context = meta_display_get_context (display);
MetaBackend *backend = meta_context_get_backend (context);
MetaX11Display *x11_display = display->x11_display;
Display *xdisplay = meta_x11_display_get_xdisplay (x11_display);
int composite_version;
Window xwindow;
if (!META_X11_DISPLAY_HAS_COMPOSITE (x11_display) ||
!META_X11_DISPLAY_HAS_DAMAGE (x11_display))
{
g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
"Missing required extension %s",
!META_X11_DISPLAY_HAS_COMPOSITE (x11_display) ?
"composite" : "damage");
return FALSE;
}
composite_version = ((x11_display->composite_major_version * 10) +
x11_display->composite_minor_version);
if (composite_version < 3)
{
g_set_error (error, G_IO_ERROR, G_IO_ERROR_FAILED,
"COMPOSITE extension 3.0 required (found %d.%d)",
x11_display->composite_major_version,
x11_display->composite_minor_version);
return FALSE;
}
determine_server_clock_source (compositor_x11);
compositor_x11->output = display->x11_display->composite_overlay_window;
xwindow = meta_backend_x11_get_xwindow (META_BACKEND_X11 (backend));
XReparentWindow (xdisplay, xwindow, compositor_x11->output, 0, 0);
meta_x11_display_clear_stage_input_region (display->x11_display);
/*
* Make sure there isn't any left-over output shape on the overlay window by
* setting the whole screen to be an output region.
*
* Note: there doesn't seem to be any real chance of that because the X
* server will destroy the overlay window when the last client using it
* exits.
*/
XFixesSetWindowShapeRegion (xdisplay, compositor_x11->output,
ShapeBounding, 0, 0, None);
/*
* Map overlay window before redirecting windows offscreen so we catch their
* contents until we show the stage.
*/
XMapWindow (xdisplay, compositor_x11->output);
compositor_x11->have_x11_sync_object = meta_sync_ring_init (xdisplay);
return TRUE;
}
static void
meta_compositor_x11_unmanage (MetaCompositor *compositor)
{
MetaDisplay *display = meta_compositor_get_display (compositor);
MetaContext *context = meta_display_get_context (display);
MetaBackend *backend = meta_context_get_backend (context);
MetaX11Display *x11_display = display->x11_display;
Display *xdisplay = x11_display->xdisplay;
Window xroot = x11_display->xroot;
Window backend_xwindow;
MetaCompositorClass *parent_class;
backend_xwindow = meta_backend_x11_get_xwindow (META_BACKEND_X11 (backend));
XReparentWindow (xdisplay, backend_xwindow, xroot, 0, 0);
/*
* This is the most important part of cleanup - we have to do this before
* giving up the window manager selection or the next window manager won't be
* able to redirect subwindows
*/
XCompositeUnredirectSubwindows (xdisplay, xroot, CompositeRedirectManual);
parent_class = META_COMPOSITOR_CLASS (meta_compositor_x11_parent_class);
parent_class->unmanage (compositor);
}
/*
* Sets an bounding shape on the COW so that the given window
* is exposed. If window is %NULL it clears the shape again.
*
* Used so we can unredirect windows, by shaping away the part
* of the COW, letting the raw window be seen through below.
*/
static void
shape_cow_for_window (MetaCompositorX11 *compositor_x11,
MetaWindow *window)
{
MetaCompositor *compositor = META_COMPOSITOR (compositor_x11);
MetaDisplay *display = meta_compositor_get_display (compositor);
Display *xdisplay = meta_x11_display_get_xdisplay (display->x11_display);
if (!window)
{
XFixesSetWindowShapeRegion (xdisplay, compositor_x11->output,
ShapeBounding, 0, 0, None);
}
else
{
XserverRegion output_region;
XRectangle screen_rect, window_bounds;
int width, height;
MtkRectangle rect;
meta_window_get_frame_rect (window, &rect);
window_bounds.x = rect.x;
window_bounds.y = rect.y;
window_bounds.width = rect.width;
window_bounds.height = rect.height;
meta_display_get_size (display, &width, &height);
screen_rect.x = 0;
screen_rect.y = 0;
screen_rect.width = width;
screen_rect.height = height;
output_region = XFixesCreateRegion (xdisplay, &window_bounds, 1);
XFixesInvertRegion (xdisplay, output_region, &screen_rect, output_region);
XFixesSetWindowShapeRegion (xdisplay, compositor_x11->output,
ShapeBounding, 0, 0, output_region);
XFixesDestroyRegion (xdisplay, output_region);
}
}
static void
set_unredirected_window (MetaCompositorX11 *compositor_x11,
MetaWindow *window)
{
MetaWindow *prev_unredirected_window = compositor_x11->unredirected_window;
if (prev_unredirected_window == window)
return;
if (prev_unredirected_window)
{
MetaWindowActor *window_actor;
MetaWindowActorX11 *window_actor_x11;
window_actor = meta_window_actor_from_window (prev_unredirected_window);
window_actor_x11 = META_WINDOW_ACTOR_X11 (window_actor);
meta_window_actor_x11_set_unredirected (window_actor_x11, FALSE);
}
shape_cow_for_window (compositor_x11, window);
compositor_x11->unredirected_window = window;
if (window)
{
MetaWindowActor *window_actor;
MetaWindowActorX11 *window_actor_x11;
window_actor = meta_window_actor_from_window (window);
window_actor_x11 = META_WINDOW_ACTOR_X11 (window_actor);
meta_window_actor_x11_set_unredirected (window_actor_x11, TRUE);
}
}
static void
maybe_unredirect_top_window (MetaCompositorX11 *compositor_x11)
{
MetaCompositor *compositor = META_COMPOSITOR (compositor_x11);
MetaWindow *window_to_unredirect = NULL;
MetaWindowActor *window_actor;
MetaWindowActorX11 *window_actor_x11;
if (meta_compositor_is_unredirect_inhibited (compositor))
goto out;
window_actor = meta_compositor_get_top_window_actor (compositor);
if (!window_actor)
goto out;
window_actor_x11 = META_WINDOW_ACTOR_X11 (window_actor);
if (!meta_window_actor_x11_should_unredirect (window_actor_x11))
goto out;
window_to_unredirect = meta_window_actor_get_meta_window (window_actor);
out:
set_unredirected_window (compositor_x11, window_to_unredirect);
}
static void
maybe_do_sync (MetaCompositor *compositor)
{
MetaCompositorX11 *compositor_x11 = META_COMPOSITOR_X11 (compositor);
if (compositor_x11->frame_has_updated_xsurfaces)
{
MetaDisplay *display = meta_compositor_get_display (compositor);
/*
* We need to make sure that any X drawing that happens before the
* XDamageSubtract() for each window above is visible to subsequent GL
* rendering; the standardized way to do this is GL_EXT_X11_sync_object.
* Since this isn't implemented yet in mesa, we also have a path that
* relies on the implementation of the open source drivers.
*
* Anything else, we just hope for the best.
*
* Xorg and open source driver specifics:
*
* The X server makes sure to flush drawing to the kernel before sending
* out damage events, but since we use DamageReportBoundingBox there may
* be drawing between the last damage event and the XDamageSubtract()
* that needs to be flushed as well.
*
* Xorg always makes sure that drawing is flushed to the kernel before
* writing events or responses to the client, so any round trip request
* at this point is sufficient to flush the GLX buffers.
*/
if (compositor_x11->have_x11_sync_object)
compositor_x11->have_x11_sync_object = meta_sync_ring_insert_wait ();
else
XSync (display->x11_display->xdisplay, False);
}
}
static void
on_before_update (ClutterStage *stage,
ClutterStageView *stage_view,
ClutterFrame *frame,
MetaCompositor *compositor)
{
maybe_do_sync (compositor);
}
static void
on_after_update (ClutterStage *stage,
ClutterStageView *stage_view,
ClutterFrame *frame,
MetaCompositor *compositor)
{
MetaCompositorX11 *compositor_x11 = META_COMPOSITOR_X11 (compositor);
if (compositor_x11->frame_has_updated_xsurfaces)
{
if (compositor_x11->have_x11_sync_object)
compositor_x11->have_x11_sync_object = meta_sync_ring_after_frame ();
compositor_x11->frame_has_updated_xsurfaces = FALSE;
}
}
static void
meta_compositor_x11_before_paint (MetaCompositor *compositor,
MetaCompositorView *compositor_view)
{
MetaCompositorX11 *compositor_x11 = META_COMPOSITOR_X11 (compositor);
MetaCompositorClass *parent_class;
maybe_unredirect_top_window (compositor_x11);
parent_class = META_COMPOSITOR_CLASS (meta_compositor_x11_parent_class);
parent_class->before_paint (compositor, compositor_view);
/* We must sync after MetaCompositor's before_paint because that's the final
* time XDamageSubtract may happen before painting (when it calls
* meta_window_actor_x11_before_paint -> handle_updates ->
* meta_surface_actor_x11_handle_updates). If a client was to redraw between
* the last damage event and XDamageSubtract, and the bounding box of the
* region didn't grow, then we will not receive a new damage report for it
* (because XDamageReportBoundingBox). Then if we haven't synchronized again
* and the same region doesn't change on subsequent frames, we have lost some
* part of the update from the client. So to ensure the correct pixels get
* composited we must sync at least once between XDamageSubtract and
* compositing, which is here. More related documentation can be found in
* maybe_do_sync.
*/
maybe_do_sync (compositor);
}
static void
meta_compositor_x11_remove_window (MetaCompositor *compositor,
MetaWindow *window)
{
MetaCompositorX11 *compositor_x11 = META_COMPOSITOR_X11 (compositor);
MetaCompositorClass *parent_class;
if (compositor_x11->unredirected_window == window)
set_unredirected_window (compositor_x11, NULL);
parent_class = META_COMPOSITOR_CLASS (meta_compositor_x11_parent_class);
parent_class->remove_window (compositor, window);
}
static int64_t
meta_compositor_x11_monotonic_to_high_res_xserver_time (MetaCompositor *compositor,
int64_t monotonic_time_us)
{
MetaCompositorX11 *compositor_x11 = META_COMPOSITOR_X11 (compositor);
int64_t now_us;
if (compositor_x11->xserver_uses_monotonic_clock)
return meta_translate_to_high_res_xserver_time (monotonic_time_us);
now_us = g_get_monotonic_time ();
if (compositor_x11->xserver_time_query_time_us == 0 ||
now_us > (compositor_x11->xserver_time_query_time_us + s2us (10)))
{
MetaDisplay *display = meta_compositor_get_display (compositor);
MetaX11Display *x11_display = display->x11_display;
uint32_t xserver_time_ms;
int64_t xserver_time_us;
compositor_x11->xserver_time_query_time_us = now_us;
xserver_time_ms =
meta_x11_display_get_current_time_roundtrip (x11_display);
xserver_time_us = ms2us (xserver_time_ms);
compositor_x11->xserver_time_offset_us = xserver_time_us - now_us;
}
return monotonic_time_us + compositor_x11->xserver_time_offset_us;
}
static MetaCompositorView *
meta_compositor_x11_create_view (MetaCompositor *compositor,
ClutterStageView *stage_view)
{
return meta_compositor_view_new (stage_view);
}
Window
meta_compositor_x11_get_output_xwindow (MetaCompositorX11 *compositor_x11)
{
return compositor_x11->output;
}
MetaCompositorX11 *
meta_compositor_x11_new (MetaDisplay *display,
MetaBackend *backend)
{
return g_object_new (META_TYPE_COMPOSITOR_X11,
"display", display,
"backend", backend,
NULL);
}
static void
meta_compositor_x11_constructed (GObject *object)
{
MetaCompositorX11 *compositor_x11 = META_COMPOSITOR_X11 (object);
MetaCompositor *compositor = META_COMPOSITOR (compositor_x11);
ClutterStage *stage = meta_compositor_get_stage (compositor);
compositor_x11->before_update_handler_id =
g_signal_connect (stage, "before-update",
G_CALLBACK (on_before_update), compositor);
compositor_x11->after_update_handler_id =
g_signal_connect (stage, "after-update",
G_CALLBACK (on_after_update), compositor);
G_OBJECT_CLASS (meta_compositor_x11_parent_class)->constructed (object);
}
static void
meta_compositor_x11_dispose (GObject *object)
{
MetaCompositorX11 *compositor_x11 = META_COMPOSITOR_X11 (object);
MetaCompositor *compositor = META_COMPOSITOR (compositor_x11);
ClutterStage *stage = meta_compositor_get_stage (compositor);
if (compositor_x11->have_x11_sync_object)
{
meta_sync_ring_destroy ();
compositor_x11->have_x11_sync_object = FALSE;
}
g_clear_signal_handler (&compositor_x11->before_update_handler_id, stage);
g_clear_signal_handler (&compositor_x11->after_update_handler_id, stage);
G_OBJECT_CLASS (meta_compositor_x11_parent_class)->dispose (object);
}
static void
meta_compositor_x11_init (MetaCompositorX11 *compositor_x11)
{
}
static void
meta_compositor_x11_class_init (MetaCompositorX11Class *klass)
{
GObjectClass *object_class = G_OBJECT_CLASS (klass);
MetaCompositorClass *compositor_class = META_COMPOSITOR_CLASS (klass);
object_class->constructed = meta_compositor_x11_constructed;
object_class->dispose = meta_compositor_x11_dispose;
compositor_class->manage = meta_compositor_x11_manage;
compositor_class->unmanage = meta_compositor_x11_unmanage;
compositor_class->before_paint = meta_compositor_x11_before_paint;
compositor_class->remove_window = meta_compositor_x11_remove_window;
compositor_class->monotonic_to_high_res_xserver_time =
meta_compositor_x11_monotonic_to_high_res_xserver_time;
compositor_class->create_view = meta_compositor_x11_create_view;
}