mirror of
https://github.com/brl/mutter.git
synced 2024-11-23 16:40:41 -05:00
29cafe6f6c
The following implicit definition for `transform()` did not correctly apply: ``` a * b = c c * invert(b) = a ``` Crucially the following did not apply for `FLIPPED-90` and `FLIPPED-270`: ``` a * invert(a) = identity ``` Fix this by applying the operations, first the flip, then the rotation, in this order and add tests to ensure correct results for the requirement above. Also drop `relative_transform()` as it only had a single user and can be replaced by `transform()`: ``` invert(a) * b = c a * c = b ``` As this is not very intuitive, ensure in tests as well. Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2459>
131 lines
4.1 KiB
C
131 lines
4.1 KiB
C
/*
|
|
* Copyright (C) 2020 Red Hat Inc.
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, see <http://www.gnu.org/licenses/>.
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include "tests/monitor-transform-tests.h"
|
|
|
|
#include "backends/meta-monitor-transform.h"
|
|
|
|
static void
|
|
test_transform (void)
|
|
{
|
|
const struct
|
|
{
|
|
MetaMonitorTransform transform;
|
|
MetaMonitorTransform other;
|
|
MetaMonitorTransform expect;
|
|
} tests[] = {
|
|
{
|
|
.transform = META_MONITOR_TRANSFORM_NORMAL,
|
|
.other = META_MONITOR_TRANSFORM_90,
|
|
.expect = META_MONITOR_TRANSFORM_90,
|
|
},
|
|
{
|
|
.transform = META_MONITOR_TRANSFORM_NORMAL,
|
|
.other = META_MONITOR_TRANSFORM_FLIPPED_90,
|
|
.expect = META_MONITOR_TRANSFORM_FLIPPED_90,
|
|
},
|
|
{
|
|
.transform = META_MONITOR_TRANSFORM_90,
|
|
.other = META_MONITOR_TRANSFORM_90,
|
|
.expect = META_MONITOR_TRANSFORM_180,
|
|
},
|
|
{
|
|
.transform = META_MONITOR_TRANSFORM_FLIPPED_90,
|
|
.other = META_MONITOR_TRANSFORM_90,
|
|
.expect = META_MONITOR_TRANSFORM_FLIPPED_180,
|
|
},
|
|
{
|
|
.transform = META_MONITOR_TRANSFORM_FLIPPED_90,
|
|
.other = META_MONITOR_TRANSFORM_180,
|
|
.expect = META_MONITOR_TRANSFORM_FLIPPED_270,
|
|
},
|
|
{
|
|
.transform = META_MONITOR_TRANSFORM_FLIPPED_180,
|
|
.other = META_MONITOR_TRANSFORM_FLIPPED_180,
|
|
.expect = META_MONITOR_TRANSFORM_NORMAL,
|
|
},
|
|
{
|
|
.transform = META_MONITOR_TRANSFORM_NORMAL,
|
|
.other = meta_monitor_transform_invert (META_MONITOR_TRANSFORM_90),
|
|
.expect = META_MONITOR_TRANSFORM_270,
|
|
},
|
|
{
|
|
.transform = META_MONITOR_TRANSFORM_FLIPPED,
|
|
.other = meta_monitor_transform_invert (META_MONITOR_TRANSFORM_90),
|
|
.expect = META_MONITOR_TRANSFORM_FLIPPED_270,
|
|
},
|
|
{
|
|
.transform = META_MONITOR_TRANSFORM_FLIPPED_180,
|
|
.other = meta_monitor_transform_invert (META_MONITOR_TRANSFORM_270),
|
|
.expect = META_MONITOR_TRANSFORM_FLIPPED_270,
|
|
},
|
|
{
|
|
.transform = META_MONITOR_TRANSFORM_FLIPPED_180,
|
|
.other =
|
|
meta_monitor_transform_invert (META_MONITOR_TRANSFORM_FLIPPED_180),
|
|
.expect = META_MONITOR_TRANSFORM_NORMAL,
|
|
},
|
|
};
|
|
int i;
|
|
MetaMonitorTransform transform;
|
|
|
|
for (i = 0; i < G_N_ELEMENTS (tests); i++)
|
|
{
|
|
MetaMonitorTransform result;
|
|
|
|
result = meta_monitor_transform_transform (tests[i].transform,
|
|
tests[i].other);
|
|
g_assert_cmpint (result, ==, tests[i].expect);
|
|
}
|
|
|
|
for (transform = 0; transform <= META_MONITOR_TRANSFORM_FLIPPED_270; transform++)
|
|
{
|
|
MetaMonitorTransform other;
|
|
MetaMonitorTransform result1;
|
|
|
|
result1 =
|
|
meta_monitor_transform_transform (transform,
|
|
meta_monitor_transform_invert (transform));
|
|
g_assert_cmpint (result1, ==, META_MONITOR_TRANSFORM_NORMAL);
|
|
|
|
for (other = 0; other <= META_MONITOR_TRANSFORM_FLIPPED_270; other++)
|
|
{
|
|
MetaMonitorTransform result2;
|
|
|
|
result1 = meta_monitor_transform_transform (transform, other);
|
|
result2 =
|
|
meta_monitor_transform_transform (result1,
|
|
meta_monitor_transform_invert (other));
|
|
g_assert_cmpint (result2, ==, transform);
|
|
|
|
result1 =
|
|
meta_monitor_transform_transform (meta_monitor_transform_invert (transform),
|
|
other);
|
|
result2 = meta_monitor_transform_transform (transform, result1);
|
|
g_assert_cmpint (result2, ==, other);
|
|
}
|
|
}
|
|
}
|
|
|
|
void
|
|
init_monitor_transform_tests (void)
|
|
{
|
|
g_test_add_func ("/util/monitor-transform/transform", test_transform);
|
|
}
|