Go to file
Georges Basile Stavracas Neto 77d5c8c928 screen-cast/monitor-stream: Immediately record scanout frames
When the before-paint function is executed, it's only purpose
is to check if there's any scanout queue, and immediately
record it if any.

However, since [1], we regressed in this specific case with the
introduction of an idle callback in the before-paint function.
The regression only happens when the PipeWire stream is using
DMA-BUF buffers, and it would operate as follows:

 1. In before-paint, when there's a scanout available, we queue
    an idle callback to capture the monitor. The idle callback
    (almost always) executes after the scanout is pulled from
    the stage view

 2. meta_screen_cast_stream_src_maybe_record_frame() is called
    by the idle callback. In the DMA-BUF case, it then runs
    meta_screen_cast_monitor_stream_src_record_to_framebuffer()

 3. In meta_screen_cast_monitor_stream_src_record_to_framebuffer(),
    because the stage view doesn't have a scanout anymore, it
    ends up calling cogl_blit_framebuffer() with the stage view
    framebuffer. This is the regression bug.

This regression presents itself in the form of the screencast
stream showing the desktop when there's an unredirected fullscreen
application window running.

Revert before-paint - and only that - back to immediately capturing
any available scanout. Only record these frames when the target
buffer is a DMA-BUF handle. Nothing is captured on before-paint if
the stream is not using DMA-BUF, since the regular paint routine
will handle these frames regularly post-paint.

[1] https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1914

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2186>
2022-01-07 19:59:36 +00:00
.gitlab/issue_templates gitlab: Add missing < in markdown comment tag 2020-02-14 03:10:28 +00:00
.gitlab-ci ci: Make run-tests.sh usable for the dist job too 2022-01-04 12:07:06 +01:00
clutter clutter/cally: Drop deprecated focus_clutter function 2022-01-05 21:43:29 +00:00
cogl cogl: Rebind the EGL image when handling damage 2021-12-13 16:09:56 +00:00
data udev-rules: Only disable modifiers on i915 2022-01-05 20:00:36 +00:00
doc startup: Optionally run (and exit with) a command 2021-11-04 04:18:32 -05:00
meson build: Check NEWS for version 2021-09-05 00:15:56 +02:00
po Update Portuguese translation 2022-01-06 23:05:58 +00:00
src screen-cast/monitor-stream: Immediately record scanout frames 2022-01-07 19:59:36 +00:00
subprojects build: bump ABI to sysprof-capture-4 2020-07-28 11:13:30 -07:00
tools tools/uncrustify: Remove space between i18n function shortcuts and ( 2021-12-09 20:59:49 +01:00
.gitignore build: bump ABI to sysprof-capture-4 2020-07-28 11:13:30 -07:00
.gitlab-ci.yml ci: Upgrade wayland-protocols to 1.24 2022-01-05 16:36:48 +00:00
check-style.py ci: Avoid deadlock while reading uncrustify output 2021-08-23 17:40:43 +02:00
config.h.meson meson: Add optional libsystemd dependency 2021-09-02 21:54:30 +00:00
COPYING Updated obsolete FSF postal address in COPYING 2014-01-12 08:44:30 +07:00
HACKING.md docs: Update coding style link 2021-11-09 19:52:14 +01:00
meson_options.txt meson: Add optional libsystemd dependency 2021-09-02 21:54:30 +00:00
meson.build wayland/dma-buf: Add basic support for DMA buffer feedback 2022-01-05 16:36:48 +00:00
mutter.doap mutter.doap: Add marge-bot as a maintainer 2020-11-16 11:59:45 +01:00
NEWS Bump version to 41.0 2021-09-19 12:41:29 +02:00
README.md docs: Add README section for default branch 2021-07-18 23:14:16 +02:00

Mutter

Mutter is a Wayland display server and X11 window manager and compositor library.

When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.

When used on top of Xorg it acts as a X11 window manager and compositing manager.

It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.

Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.

Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.

Contributing

To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.

It can be useful to look at the documentation available at the Wiki.

Coding style and conventions

See HACKING.md.

Git messages

Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit. Try to always prefix commit subjects with a relevant topic, such as compositor: or clutter/actor:, and it's always better to write too much in the commit message body than too little.

Default branch

The default development branch is main. If you still have a local checkout under the old name, use:

git checkout master
git branch -m master main
git fetch
git branch --unset-upstream
git branch -u origin/main
git symbolic-ref refs/remotes/origin/HEAD refs/remotes/origin/main

License

Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.