73db35c53c
Before this commit meta_kms_crtc_read_state was overwriting the entire MetaKmsCrtcState struct stored in crtc->current_state including the gamma (sub)struct. This effectively zero-s the gamma struct each time before calling read_gamma_state, setting the pointers where the previous gamma values were stored to NULL without freeing the memory. Luckily this zero-ing also sets gamma.size to 0, causing read_gamma_state to re-alloc the arrays on each meta_kms_crtc_update_state call. But this does mean that were leaking the old gamma arrays on each meta_kms_crtc_update_state call. This commit fixes this by making meta_kms_crtc_read_state only overwrite the other values in the MetaKmsCrtcState struct and leaving the gamma sub-struct alone, this will make read_gamma_state correctly re-use the gamma tables if the gamma table size is unchanged; or re-alloc them (freeing the old ones) if the size has changed, fixing the memory leak. https://gitlab.gnome.org/GNOME/mutter/merge_requests/713 |
||
|---|---|---|
| .gitlab-ci | ||
| clutter | ||
| cogl | ||
| data | ||
| doc | ||
| po | ||
| src | ||
| tools | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| config.h.meson | ||
| COPYING | ||
| meson_options.txt | ||
| meson.build | ||
| mutter.doap | ||
| NEWS | ||
| README.md | ||
Mutter
Mutter is a Wayland display server and X11 window manager and compositor library.
When used as a Wayland display server, it runs on top of KMS and libinput. It implements the compositor side of the Wayland core protocol as well as various protocol extensions. It also has functionality related to running X11 applications using Xwayland.
When used on top of Xorg it acts as a X11 window manager and compositing manager.
It contains functionality related to, among other things, window management, window compositing, focus tracking, workspace management, keybindings and monitor configuration.
Internally it uses a fork of Cogl, a hardware acceleration abstraction library used to simplify usage of OpenGL pipelines, as well as a fork af Clutter, a scene graph and user interface toolkit.
Mutter is used by, for example, GNOME Shell, the GNOME core user interface, and by Gala, elementary OS's window manager. It can also be run standalone, using the command "mutter", but just running plain mutter is only intended for debugging purposes.
Contributing
To contribute, open merge requests at https://gitlab.gnome.org/GNOME/mutter.
The coding style used is primarily the GNU flavor of the GNOME coding
style
with some minor additions such as preferring stdint.h types over GLib
fundamental types, and a soft 80 character line limit. However, in general,
look at the file you're editing for inspiration.
Commit messages should follow the GNOME commit message guidelines. We require an URL to either an issue or a merge request in each commit.
License
Mutter is distributed under the terms of the GNU General Public License, version 2 or later. See the COPYING file for detalis.