mirror of
https://github.com/brl/mutter.git
synced 2025-01-23 09:59:03 +00:00
5a86286aba
This optimization breaks our use of XRRScreenResources' timestamps to detect hotplugs in case one of the outputs is disconnected and the remaining ones don't need any mode, position or transform adjustments. In that scenario, when applying the new configuration, we resize the X screen but never call XRRSetCrtcConfig() and since XRRSetScreenSize() doesn't take a timestamp and the X server doesn't update its last set timestamp, when we next get a RRScreenChangeNotify and update ourselves, XRRScreenResources.timestamp will still be smaller than XRRScreenResources.configTimestamp which makes us think we're seeing a new hotplug. We just don't enter an endless loop because the screen size that we keep applying is always the same and the X server short-circuits and stops sending us RRScreenChangeNotifys. Always calling XRRSetCrtcConfig() ensures that the last set timestamp will be bigger than configTimestamp in the next event and thus making us trigger the monitors-changed signal properly. Note that the X server already does basically the same checks that we're removing here, so doing this shouldn't be a significant efficiency loss. See http://cgit.freedesktop.org/xorg/xserver/tree/randr/rrcrtc.c?h=server-1.16-branch#n539