mirror of
https://github.com/brl/mutter.git
synced 2024-12-23 03:22:04 +00:00
5991f53c84
Previously we were using a mask of 0x1 for the lifetime of the stencil.
This was wrong for two reasons:
* The intersection algorithm needs to count up to a maximum 2, so a
mask of 1 would clamp to 1 instead. Then decrementing all pixels
resulted in all pixels being zero even though we want some to be 1.
So the stencil then blocked some color buffer pixels being rendered.
* The lifetime of the mask was too long. By leaving it non-zero at
the end of the function we could accidentally end up modifying the
stencil contents during our later color buffer paints.
This fixes missing rendering of some actors seen in gnome-shell with
test case: `env COGL_DEBUG=stencilling CLUTTER_PAINT=disable-clipped-redraws`
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1873>
|
||
|---|---|---|
| .. | ||
| cogl | ||
| cogl-pango | ||
| test-fixtures | ||
| tests | ||
| .gitignore | ||
| cogl-config.h.meson | ||
| cogl-mutter-config.h.in | ||
| config-custom.h | ||
| meson.build | ||