mirror of
https://github.com/brl/mutter.git
synced 2024-11-26 18:11:05 -05:00
272e227109
cogl_clip_push() which accepts a rectangle in model space shouldn't have been defined to take x,y,width,height arguments because this isn't consistant with other Cogl API dealing with model space rectangles. If you are using a coordinate system with the origin at the center and the y+ extending up, then x,y,width,height isn't as natural as (x0,y0)(x1,y1). This API has now been replace with cogl_clip_push_rectangle() (As a general note: the Cogl API should only use the x,y,width,height style when the appropriate coordinate space is defined by Cogl to have a top left origin. E.g. window coordinates, or potentially texture coordinates) cogl_clip_push_window_rect() shouldn't have been defined to take float arguments since we only clip with integral pixel precision. We also shouldn't have abbreviated "rectangle". This API has been replaced with cogl_clip_push_window_rectangle() cogl_clip_ensure() wasn't documented at all in Clutter 1.0 and probably no one even knew it existed. This API isn't useful, and so it's now deprecated. If no one complains we may remove the API altogether for Clutter 1.2. cogl_clip_stack_save() and cogl_clip_stack_restore() were originally added to allow us to save/restore the clip when switching to/from offscreen rendering. Now that offscreen draw buffers are defined to own their clip state and the state will be automatically saved and restored this API is now redundant and so deprecated. |
||
|---|---|---|
| .. | ||
| conform | ||
| data | ||
| interactive | ||
| micro-bench | ||
| tools | ||
| .gitignore | ||
| Makefile.am | ||
| README | ||
Outline of test categories: The conform/ tests should be non-interactive unit-tests that verify a single feature is behaving as documented. See conform/ADDING_NEW_TESTS for more details. The micro-bench/ tests should be focused perfomance test, ideally testing a single metric. Please never forget that these tests are synthetec and if you are using them then you understand what metric is being tested. They probably don't reflect any real world application loads and the intention is that you use these tests once you have already determined the crux of your problem and need focused feedback that your changes are indeed improving matters. There is no exit status requirements for these tests, but they should give clear feedback as to their performance. If the framerate is the feedback metric, then the test should forcibly enable FPS debugging. The interactive/ tests are any tests whos status can not be determined without a user looking at some visual output, or providing some manual input etc. This covers most of the original Clutter tests. Ideally some of these tests will be migrated into the conformance/ directory so they can be used in automated nightly tests. Other notes: All tests should ideally include a detailed description in the source explaining exactly what the test is for, how the test was designed to work, and possibly a rationale for the approach taken for testing.