mutter/src/wayland/meta-wayland-pointer-gesture-swipe.c
msizanoen1 992e169d84 wayland/pointer-gestures: Fix crash in get_*_gesture after pointer is destroyed
Properly handle cases where the pointer object has already been
destroyed to prevent the compositor from crashing with a null pointer
dereference when a client invokes a get_*_gesture method after the
pointer object is destroyed e.g. when the current login session is not on
foreground.

Closes: https://gitlab.gnome.org/GNOME/mutter/-/issues/2237
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/2690>
2022-11-25 15:40:12 +00:00

192 lines
6.0 KiB
C

/*
* Wayland Support
*
* Copyright (C) 2015 Red Hat
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
* 02111-1307, USA.
*
* Author: Carlos Garnacho <carlosg@gnome.org>
*/
#include "config.h"
#include "wayland/meta-wayland-pointer-gesture-swipe.h"
#include <glib.h>
#include "wayland/meta-wayland-pointer.h"
#include "wayland/meta-wayland-seat.h"
#include "wayland/meta-wayland-surface.h"
#include "pointer-gestures-unstable-v1-server-protocol.h"
static void
handle_swipe_begin (MetaWaylandPointer *pointer,
const ClutterEvent *event)
{
MetaWaylandPointerClient *pointer_client;
MetaWaylandSeat *seat;
struct wl_resource *resource;
uint32_t serial, fingers;
pointer_client = pointer->focus_client;
seat = meta_wayland_pointer_get_seat (pointer);
serial = wl_display_next_serial (seat->wl_display);
fingers = clutter_event_get_touchpad_gesture_finger_count (event);
pointer_client->active_touchpad_gesture = event->type;
wl_resource_for_each (resource, &pointer_client->swipe_gesture_resources)
{
zwp_pointer_gesture_swipe_v1_send_begin (resource, serial,
clutter_event_get_time (event),
pointer->focus_surface->resource,
fingers);
}
}
static void
handle_swipe_update (MetaWaylandPointer *pointer,
const ClutterEvent *event)
{
MetaWaylandPointerClient *pointer_client;
struct wl_resource *resource;
gdouble dx, dy;
pointer_client = pointer->focus_client;
clutter_event_get_gesture_motion_delta (event, &dx, &dy);
wl_resource_for_each (resource, &pointer_client->swipe_gesture_resources)
{
zwp_pointer_gesture_swipe_v1_send_update (resource,
clutter_event_get_time (event),
wl_fixed_from_double (dx),
wl_fixed_from_double (dy));
}
}
static void
broadcast_end (MetaWaylandPointer *pointer,
uint32_t serial,
uint32_t time,
gboolean cancelled)
{
MetaWaylandPointerClient *pointer_client;
struct wl_resource *resource;
pointer_client = pointer->focus_client;
wl_resource_for_each (resource, &pointer_client->swipe_gesture_resources)
{
zwp_pointer_gesture_swipe_v1_send_end (resource, serial,
time, cancelled);
}
pointer_client->active_touchpad_gesture = CLUTTER_NOTHING;
}
static void
handle_swipe_end (MetaWaylandPointer *pointer,
const ClutterEvent *event)
{
MetaWaylandSeat *seat;
gboolean cancelled = FALSE;
uint32_t serial;
seat = meta_wayland_pointer_get_seat (pointer);
serial = wl_display_next_serial (seat->wl_display);
if (event->touchpad_swipe.phase == CLUTTER_TOUCHPAD_GESTURE_PHASE_CANCEL)
cancelled = TRUE;
broadcast_end (pointer, serial,
clutter_event_get_time (event),
cancelled);
}
gboolean
meta_wayland_pointer_gesture_swipe_handle_event (MetaWaylandPointer *pointer,
const ClutterEvent *event)
{
if (event->type != CLUTTER_TOUCHPAD_SWIPE)
return FALSE;
if (!pointer->focus_client)
return FALSE;
switch (event->touchpad_swipe.phase)
{
case CLUTTER_TOUCHPAD_GESTURE_PHASE_BEGIN:
handle_swipe_begin (pointer, event);
break;
case CLUTTER_TOUCHPAD_GESTURE_PHASE_UPDATE:
handle_swipe_update (pointer, event);
break;
case CLUTTER_TOUCHPAD_GESTURE_PHASE_END:
case CLUTTER_TOUCHPAD_GESTURE_PHASE_CANCEL:
handle_swipe_end (pointer, event);
break;
default:
return FALSE;
}
return TRUE;
}
static void
pointer_gesture_swipe_release (struct wl_client *client,
struct wl_resource *resource)
{
wl_resource_destroy (resource);
}
static const struct zwp_pointer_gesture_swipe_v1_interface pointer_gesture_swipe_interface = {
pointer_gesture_swipe_release
};
void
meta_wayland_pointer_gesture_swipe_create_new_resource (MetaWaylandPointer *pointer,
struct wl_client *client,
struct wl_resource *pointer_resource,
uint32_t id)
{
MetaWaylandPointerClient *pointer_client;
struct wl_resource *res;
res = wl_resource_create (client, &zwp_pointer_gesture_swipe_v1_interface,
wl_resource_get_version (pointer_resource), id);
wl_resource_set_implementation (res, &pointer_gesture_swipe_interface, pointer,
meta_wayland_pointer_unbind_pointer_client_resource);
if (pointer)
{
pointer_client = meta_wayland_pointer_get_pointer_client (pointer, client);
g_return_if_fail (pointer_client != NULL);
wl_list_insert (&pointer_client->swipe_gesture_resources,
wl_resource_get_link (res));
}
}
void
meta_wayland_pointer_gesture_swipe_cancel (MetaWaylandPointer *pointer,
uint32_t serial)
{
broadcast_end (pointer, serial,
us2ms (g_get_monotonic_time ()),
TRUE);
}