mirror of
https://github.com/brl/mutter.git
synced 2025-03-19 09:45:16 +00:00

2004-10-04 Elijah Newren <newren@math.utah.edu> Fix a variety of focus race conditions in all focus modes, or at least make them harder to trigger (fixes #152000) * src/core.[ch] (meta_core_user_lower_and_unfocus): add a timestamp parameter; pass it along to meta_workspace_focus_default_window * src/display.[ch] (meta_display_get_current_time_roundtrip): new function * src/display.c (event_callback): pass a timestamp to the meta_workspace_activate and meta_workspace_focus_default_window function calls * src/frames.c (meta_frames_button_press_event): pass a timestamp to meta_core_user_lower_and_unfocus * src/keybindings.c (handle_activate_workspace): pass a timestamp to meta_workspace_activate, (process_workspace_switch_grab): pass a timestamp to meta_workspace_focus_default_window and meta_workspace_activate, (handle_toggle_desktop): pass a timestamp to meta_workspace_focus_default_window, (do_handle_move_to_workspace): pass a timestamp to meta_workspace_activate_with_focus, (handle_workspace_switch): meta_workspace_activate * src/screen.c (meta_screen_new): pass a timestamp to meta_workspace_activate * src/window.c (meta_window_free): pass a timestamp to meta_workspace_focus_default_window, (idle_calc_showing): don't increment the focus sentinel here, (meta_window_minimize): pass a timestamp to meta_workspace_focus_default_window, (meta_window_client_message), pass a timestamp to meta_workspace_focus_default_window * src/workspace.h (meta_workspace_activate): add timestamp parameter, (meta_workspace_activate_with_focus): add timestamp parameter, (meta_workspace_focus_default_window): add timestamp parameter * src/workspace.c (meta_workspace_focus_mru_window): make this function take a timestamp and use it for meta_window_focus or XSetInputFocus, (meta_workspace_activate_with_focus): make this function take a timestamp and pass it along to meta_window_focus and meta_workspace_focus_default_window, (meta_workspace_activate): make this function take a timestamp and pass it to meta_workspace_activate_with_focus), (meta_workspace_focus_default_window): make this function take a timestamp, warn if its 0 but try to handle that case sanely, and pass the timestamp on to meta_window_focus or meta_workspace_focus_mru_window or XSetInputFocus
96 lines
3.5 KiB
C
96 lines
3.5 KiB
C
/* Metacity Workspaces */
|
|
|
|
/*
|
|
* Copyright (C) 2001 Havoc Pennington
|
|
*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program; if not, write to the Free Software
|
|
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
|
|
* 02111-1307, USA.
|
|
*/
|
|
|
|
#ifndef META_WORKSPACE_H
|
|
#define META_WORKSPACE_H
|
|
|
|
#include "window.h"
|
|
|
|
/* Negative to avoid conflicting with real workspace
|
|
* numbers
|
|
*/
|
|
typedef enum
|
|
{
|
|
META_MOTION_UP = -1,
|
|
META_MOTION_DOWN = -2,
|
|
META_MOTION_LEFT = -3,
|
|
META_MOTION_RIGHT = -4
|
|
} MetaMotionDirection;
|
|
|
|
struct _MetaWorkspace
|
|
{
|
|
MetaScreen *screen;
|
|
|
|
GList *windows;
|
|
GList *mru_list;
|
|
|
|
MetaRectangle all_work_areas;
|
|
MetaRectangle *work_areas;
|
|
GSList *left_struts;
|
|
GSList *right_struts;
|
|
GSList *top_struts;
|
|
GSList *bottom_struts;
|
|
guint work_areas_invalid : 1;
|
|
};
|
|
|
|
MetaWorkspace* meta_workspace_new (MetaScreen *screen);
|
|
void meta_workspace_free (MetaWorkspace *workspace);
|
|
void meta_workspace_add_window (MetaWorkspace *workspace,
|
|
MetaWindow *window);
|
|
void meta_workspace_remove_window (MetaWorkspace *workspace,
|
|
MetaWindow *window);
|
|
void meta_workspace_relocate_windows (MetaWorkspace *workspace,
|
|
MetaWorkspace *new_home);
|
|
/* don't confuse with meta_window_visible_on_workspace() */
|
|
gboolean meta_workspace_contains_window (MetaWorkspace *workspace,
|
|
MetaWindow *window);
|
|
void meta_workspace_activate_with_focus (MetaWorkspace *workspace,
|
|
MetaWindow *focus_this,
|
|
Time timestamp);
|
|
void meta_workspace_activate (MetaWorkspace *workspace,
|
|
Time timestamp);
|
|
int meta_workspace_index (MetaWorkspace *workspace);
|
|
GList* meta_workspace_list_windows (MetaWorkspace *workspace);
|
|
|
|
void meta_workspace_invalidate_work_area (MetaWorkspace *workspace);
|
|
|
|
|
|
void meta_workspace_get_work_area_for_xinerama (MetaWorkspace *workspace,
|
|
int which_xinerama,
|
|
MetaRectangle *area);
|
|
void meta_workspace_get_work_area_all_xineramas (MetaWorkspace *workspace,
|
|
MetaRectangle *area);
|
|
|
|
void meta_workspace_focus_default_window (MetaWorkspace *workspace,
|
|
MetaWindow *not_this_one,
|
|
Time timestamp);
|
|
|
|
MetaWorkspace* meta_workspace_get_neighbor (MetaWorkspace *workspace,
|
|
MetaMotionDirection direction);
|
|
|
|
const char* meta_workspace_get_name (MetaWorkspace *workspace);
|
|
|
|
#endif
|
|
|
|
|
|
|
|
|