mutter/src/x11/meta-selection-source-x11.c
Sebastian Keller dbd6e74d3c x11: Let selection input streams create their own window
When there are two (or more) concurrent XConvertSelection requests with
the same target, selection and window and the data is large enough for
SelectionNotify events to overlap. This can result in the affected streams
being considered completed without any data being transferred.

While regular mutter/shell code does not make use of concurrent
XConvertSelection requests with the same targets, some extensions might.
Such as for example a clipboard manager that like the built-in clipboard
manager tries to read the selection on owner-changed.

One potential solution would be to make sure the event is for the correct
property, but not all clients seem to support concurrent requests for the
same targets but different properties on the same window.

This commit instead changes the streams to use their own window which
seems to be more widely supported.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4034

Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1812>
2022-01-07 02:21:28 +01:00

274 lines
9.1 KiB
C

/*
* Copyright (C) 2018 Red Hat
*
* This program is free software; you can redistribute it and/or
* modify it under the terms of the GNU General Public License as
* published by the Free Software Foundation; either version 2 of the
* License, or (at your option) any later version.
*
* This program is distributed in the hope that it will be useful, but
* WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
* General Public License for more details.
*
* You should have received a copy of the GNU General Public License
* along with this program; if not, write to the Free Software
* Foundation, Inc., 59 Temple Place - Suite 330, Boston, MA
* 02111-1307, USA.
*
* Author: Carlos Garnacho <carlosg@gnome.org>
*/
#include "config.h"
#include <gdk/gdkx.h>
#include "x11/meta-x11-selection-input-stream-private.h"
#include "x11/meta-selection-source-x11-private.h"
#define MAX_MIMETYPE_SIZE 4096
struct _MetaSelectionSourceX11
{
MetaSelectionSource parent_instance;
MetaX11Display *x11_display;
GList *mimetypes;
Window owner;
Atom xselection;
uint32_t timestamp;
};
G_DEFINE_TYPE (MetaSelectionSourceX11, meta_selection_source_x11,
META_TYPE_SELECTION_SOURCE)
static void
stream_new_cb (GObject *source,
GAsyncResult *res,
GTask *task)
{
GInputStream *stream;
GError *error = NULL;
stream = meta_x11_selection_input_stream_new_finish (res, NULL, NULL, &error);
if (stream)
g_task_return_pointer (task, stream, g_object_unref);
else
g_task_return_error (task, error);
g_object_unref (task);
}
static void
meta_selection_source_x11_finalize (GObject *object)
{
MetaSelectionSourceX11 *source_x11 = META_SELECTION_SOURCE_X11 (object);
g_list_free_full (source_x11->mimetypes, g_free);
G_OBJECT_CLASS (meta_selection_source_x11_parent_class)->finalize (object);
}
static void
meta_selection_source_x11_read_async (MetaSelectionSource *source,
const gchar *mimetype,
GCancellable *cancellable,
GAsyncReadyCallback callback,
gpointer user_data)
{
MetaSelectionSourceX11 *source_x11 = META_SELECTION_SOURCE_X11 (source);
GTask *task;
task = g_task_new (source, cancellable, callback, user_data);
g_task_set_source_tag (task, meta_selection_source_x11_read_async);
if (strcmp (mimetype, "text/plain") == 0 &&
g_list_find_custom (source_x11->mimetypes, "STRING",
(GCompareFunc) g_strcmp0))
mimetype = "STRING";
else if (strcmp (mimetype, "text/plain;charset=utf-8") == 0 &&
g_list_find_custom (source_x11->mimetypes, "UTF8_STRING",
(GCompareFunc) g_strcmp0))
mimetype = "UTF8_STRING";
meta_x11_selection_input_stream_new_async (source_x11->x11_display,
gdk_x11_get_xatom_name (source_x11->xselection),
mimetype,
source_x11->timestamp,
G_PRIORITY_DEFAULT,
cancellable,
(GAsyncReadyCallback) stream_new_cb,
task);
}
static GInputStream *
meta_selection_source_x11_read_finish (MetaSelectionSource *source,
GAsyncResult *result,
GError **error)
{
g_return_val_if_fail (g_task_is_valid (result, source), NULL);
g_return_val_if_fail (g_task_get_source_tag (G_TASK (result)) ==
meta_selection_source_x11_read_async, NULL);
return g_task_propagate_pointer (G_TASK (result), error);
}
static GList *
meta_selection_source_x11_get_mimetypes (MetaSelectionSource *source)
{
MetaSelectionSourceX11 *source_x11 = META_SELECTION_SOURCE_X11 (source);
return g_list_copy_deep (source_x11->mimetypes, (GCopyFunc) g_strdup, NULL);
}
static void
meta_selection_source_x11_class_init (MetaSelectionSourceX11Class *klass)
{
GObjectClass *object_class = G_OBJECT_CLASS (klass);
MetaSelectionSourceClass *source_class = META_SELECTION_SOURCE_CLASS (klass);
object_class->finalize = meta_selection_source_x11_finalize;
source_class->read_async = meta_selection_source_x11_read_async;
source_class->read_finish = meta_selection_source_x11_read_finish;
source_class->get_mimetypes = meta_selection_source_x11_get_mimetypes;
}
static void
meta_selection_source_x11_init (MetaSelectionSourceX11 *source)
{
}
static GList *
atoms_to_mimetypes (MetaX11Display *display,
GBytes *bytes)
{
GList *mimetypes = NULL;
const Atom *atoms;
gsize size;
guint i, n_atoms;
gboolean utf8_string_found = FALSE, utf8_text_plain_found = FALSE;
gboolean string_found = FALSE, text_plain_found = FALSE;
atoms = g_bytes_get_data (bytes, &size);
n_atoms = size / sizeof (Atom);
for (i = 0; i < n_atoms; i++)
{
const gchar *mimetype;
mimetype = gdk_x11_get_xatom_name (atoms[i]);
mimetypes = g_list_prepend (mimetypes, g_strdup (mimetype));
utf8_text_plain_found |= strcmp (mimetype, "text/plain;charset=utf-8") == 0;
text_plain_found |= strcmp (mimetype, "text/plain") == 0;
utf8_string_found |= strcmp (mimetype, "UTF8_STRING") == 0;
string_found |= strcmp (mimetype, "STRING") == 0;
}
/* Ensure non-x11 clients get well-known mimetypes */
if (string_found && !text_plain_found)
mimetypes = g_list_prepend (mimetypes, g_strdup ("text/plain"));
if (utf8_string_found && !utf8_text_plain_found)
mimetypes = g_list_prepend (mimetypes, g_strdup ("text/plain;charset=utf-8"));
return mimetypes;
}
static void
read_mimetypes_cb (GInputStream *stream,
GAsyncResult *res,
GTask *task)
{
MetaSelectionSourceX11 *source_x11 = g_task_get_task_data (task);
GError *error = NULL;
GBytes *bytes;
bytes = g_input_stream_read_bytes_finish (stream, res, &error);
if (error)
{
g_task_return_error (task, error);
g_object_unref (task);
g_object_unref (stream);
return;
}
source_x11->mimetypes = atoms_to_mimetypes (source_x11->x11_display, bytes);
g_bytes_unref (bytes);
g_task_return_pointer (task,
g_object_ref (g_task_get_task_data (task)),
g_object_unref);
g_object_unref (task);
g_object_unref (stream);
}
static void
get_mimetypes_cb (GObject *source,
GAsyncResult *res,
GTask *task)
{
GInputStream *stream;
GError *error = NULL;
stream = meta_x11_selection_input_stream_new_finish (res, NULL, NULL, &error);
if (error)
{
g_task_return_error (task, error);
g_object_unref (task);
return;
}
g_input_stream_read_bytes_async (stream,
MAX_MIMETYPE_SIZE,
G_PRIORITY_DEFAULT,
g_task_get_cancellable (task),
(GAsyncReadyCallback) read_mimetypes_cb,
task);
}
void
meta_selection_source_x11_new_async (MetaX11Display *x11_display,
Window owner,
uint32_t timestamp,
Atom xselection,
GCancellable *cancellable,
GAsyncReadyCallback callback,
gpointer user_data)
{
MetaSelectionSourceX11 *source;
GTask *task;
source = g_object_new (META_TYPE_SELECTION_SOURCE_X11, NULL);
source->x11_display = x11_display;
source->owner = owner;
source->timestamp = timestamp;
source->xselection = xselection;
task = g_task_new (NULL, cancellable, callback, user_data);
g_task_set_source_tag (task, meta_selection_source_x11_new_async);
g_task_set_task_data (task, source, g_object_unref);
meta_x11_selection_input_stream_new_async (x11_display,
gdk_x11_get_xatom_name (xselection),
"TARGETS",
timestamp,
G_PRIORITY_DEFAULT,
cancellable,
(GAsyncReadyCallback) get_mimetypes_cb,
task);
}
MetaSelectionSource *
meta_selection_source_x11_new_finish (GAsyncResult *result,
GError **error)
{
GTask *task = G_TASK (result);
g_return_val_if_fail (g_task_is_valid (task, NULL), NULL);
g_return_val_if_fail (g_task_get_source_tag (task) ==
meta_selection_source_x11_new_async, NULL);
return g_task_propagate_pointer (task, error);
}