Adel Gadllah
a378faf495
stack-tracker: Fix unitialized variable
2014-04-20 16:02:48 +02:00
Jasper St. Pierre
c9e99ebbbf
pointer: Move update up
...
It seems that I forgot or messed this up in one of my reshufflings.
2014-04-18 18:56:01 -04:00
Jasper St. Pierre
020f209c45
pointer: Split out the code that gets the proper focus surface as well
2014-04-18 18:56:01 -04:00
Jasper St. Pierre
45df3e41c5
pointer: Split out the code that sets the focus surface
2014-04-18 18:56:01 -04:00
Jasper St. Pierre
1a723954fc
pointer: Only the focus_surface should only be influenced by the grab
...
... not the normal current. That should *always* be the surface under
the pointer, regardless of events.
2014-04-18 18:56:01 -04:00
Jasper St. Pierre
3e554efc70
pointer: Clean up repick_for_event a bit
2014-04-18 18:56:01 -04:00
Jasper St. Pierre
d68da0b8cf
pointer: Merge update_current_focus and repick_for_event
...
In order to correctly fix the issue to make sure we only set the
focused surface to NULL during a grab, but not the current surface,
we need to merge update_current_surface back into repick_for_event
so we have more control over the behavior here.
2014-04-18 18:56:01 -04:00
Jasper St. Pierre
de7a644656
pointer: Unset the window cursor when we do a pick
...
... not when we do an update.
We only repick when we handle events, not when we update. Perhaps
this is a mistake.
Since update runs before handle_event, this means that when we
drop a grab, update will notice the NULL surface, since we haven't
repicked after the event, and then we'll repick the correct surface.
The end result is that you see a root cursor after a grab ends,
rather than the correct window cursor.
This doesn't fix it, since the current surface becomes NULL when
we start the grab. But it does make the code here more correct when
we fix that bug.
2014-04-18 18:56:01 -04:00
Jasper St. Pierre
16bcbd1a34
pointer: Reindent
2014-04-18 18:56:01 -04:00
Jasper St. Pierre
29439f8de2
wayland-surface: Fix offset with window dragging
...
The grab_x / grab_y here were converted from fixed integers to
floats, but we forgot to update one place in the code that used
them as fixed integers.
2014-04-18 18:23:27 -04:00
Jasper St. Pierre
97a69cee5a
wayland-surface: Simplify move_double_buffered_state
...
The majority of the data we can simply copy from one to the other.
2014-04-18 18:23:27 -04:00
Jasper St. Pierre
2e2dd247ce
wayland: Rename pending_surface_state => pending
...
This matches what's normally done.
2014-04-18 18:15:41 -04:00
Jasper St. Pierre
de6054d557
wayland: Remove an extraneous variable
2014-04-18 18:15:41 -04:00
Jasper St. Pierre
db56a7cecb
wayland: Rename DoubleBufferedState to PendingState
...
I was talking with other people and they became confused at the
term "double-buffered", since we were also talking about
double-buffering in general, e.g. swapping between two buffers.
Instead, we'll adapt the "pending state" nomenclature that we
already use for the field / variable names.
2014-04-18 18:15:36 -04:00
Jasper St. Pierre
f92c1af24a
wayland-surface: Merge actor_surface_commit back in
...
Since we do it unconditionally now, the code flows better
if it's inline with commit_double_buffered_state.
2014-04-18 15:43:26 -04:00
Jasper St. Pierre
4ab71ec942
wayland: Make subsurfaces reactive
2014-04-18 12:26:31 -04:00
Jasper St. Pierre
2748661f63
pointer: Remove our own position tracking
...
Use the coords inside ClutterInputDevice instead.
2014-04-18 12:26:31 -04:00
Jasper St. Pierre
aee074b11d
pointer: Remove unused field
2014-04-18 12:26:31 -04:00
Jasper St. Pierre
5f29b8c206
pointer/keyboard: Rearrange slightly
2014-04-18 12:26:30 -04:00
Jasper St. Pierre
92340fd8da
display: Kill #if 0'd support for _NET_RESTACK_WINDOW requests
...
The code has been dead and broken for a long, long time now.
2014-04-18 10:12:11 -04:00
Jasper St. Pierre
7c6c4d63c5
seat: Move the keyboard resource creation over to MetaWaylandKeyboard
2014-04-17 19:15:53 -04:00
Jasper St. Pierre
5d43e33032
seat: Don't set the data device key focus on get_keyboard creation
...
It's not necessary, as we don't use anything from the protocol
keyboard at all.
2014-04-17 19:15:53 -04:00
Jasper St. Pierre
45a8a3f490
seat: Move pointer event handling to MetaWaylandPointer as well
...
Now everything that deals with the pointer is inside meta-wayland-pointer.c
2014-04-17 19:15:53 -04:00
Jasper St. Pierre
bdf55bc674
seat: Rewrite event handling in terms of MetaWaylandPointer
2014-04-17 19:15:53 -04:00
Jasper St. Pierre
e15c260e56
seat: Group CLUTTER_SCROLL handling together with other pointer events
2014-04-17 19:15:53 -04:00
Jasper St. Pierre
65ed8a817d
seat: Don't save the current stage ourselves
...
ClutterInputDevice already saves it.
2014-04-17 19:15:53 -04:00
Jasper St. Pierre
a8d2dfd14f
seat: Don't require an event to repick()
...
We always pass NULL, and anywhere where we want to pass an event
should be handled internally.
2014-04-17 19:15:53 -04:00
Jasper St. Pierre
e02bf13206
seat: Remove incorrect comment above repick
2014-04-17 19:15:53 -04:00
Jasper St. Pierre
4b7d77864a
seat: Move update_pointer to MetaWaylandPointer
2014-04-17 19:15:52 -04:00
Jasper St. Pierre
72e4d42267
seat: Reorder handle_event helpers near handle_event
2014-04-17 19:15:52 -04:00
Jasper St. Pierre
1abdd7be10
seat: Move pointer interface over to MetaWaylandPointer
2014-04-17 19:15:52 -04:00
Jasper St. Pierre
f3d88ca1d1
seat: Rewrite the pointer interface in terms of MetaWaylandPointer
2014-04-17 19:15:52 -04:00
Jasper St. Pierre
15d89d451f
seat: Move update_cursor_surface to the end
...
It's now only a public API.
2014-04-17 19:15:52 -04:00
Jasper St. Pierre
4510b82361
seat: Move set_cursor_surface and all that tracking to MetaWaylandPointer
2014-04-17 19:15:52 -04:00
Jasper St. Pierre
ae0853ed86
seat: Move cursor storage to MetaWaylandPointer
2014-04-17 19:15:52 -04:00
Jasper St. Pierre
76544ff6e1
seat: Rewrite get_pointer / get_keyboard in terms of MetaWaylandPointer
2014-04-17 19:15:52 -04:00
Jasper St. Pierre
dde96951a7
seat: Rewrite handle_scroll in terms of MetaWaylandPointer
2014-04-17 19:15:52 -04:00
Jasper St. Pierre
24eb737858
keyboard: Remove the useless return value of init
2014-04-17 19:15:52 -04:00
Jasper St. Pierre
ddc7938961
keyboard: Reformat
2014-04-17 19:15:51 -04:00
Jasper St. Pierre
4f2dc77ec3
keyboard: Reorder
...
The correct order is:
init
release
update
handle_event
set_focus
start_grab
end_grab
other stuff
2014-04-17 19:15:51 -04:00
Jasper St. Pierre
678fa52ae1
seat: Reformat
2014-04-17 19:15:51 -04:00
Jasper St. Pierre
1be97f3d59
seat: Reorder
2014-04-17 19:15:51 -04:00
Jasper St. Pierre
30ecd7c770
keyboard: Gobble up key events whenever we have a focused surface
...
If we have a focused surface, we need to eat up key events, not
just if we have a non-empty focus resource list. The latter would
happen if we have a focused client but it never called get_keyboard.
2014-04-17 19:15:51 -04:00
Jasper St. Pierre
0dd27edb91
xwayland: Remove some unused includes
2014-04-17 16:23:37 -04:00
Jasper St. Pierre
6a44f04b51
xwayland: Stop using UNIX signals for readiness
...
The latest Xorg / Xwayland has support for -displayfd being used
in conjunction with an explicit display number. Use that to know
when the X server is ready, rather than UNIX signals, because
they're UNIX signals.
2014-04-17 16:23:37 -04:00
Jasper St. Pierre
745134e066
xwayland: Rename sp to something a bit more handy
...
We also want to create a socketpair for -displayfd instead
of using signals.
2014-04-17 16:23:37 -04:00
Jasper St. Pierre
72b1a2837d
xwayland: Clean up display finding code
...
Split out and make it more manageable.
2014-04-17 16:23:37 -04:00
Jasper St. Pierre
e5ab4f13f1
xwayland: Put the filename in the error message
2014-04-17 16:23:37 -04:00
Jasper St. Pierre
14deeef8a7
xwayland: Use %m instead of explicit strerror
2014-04-17 16:23:37 -04:00
Jasper St. Pierre
57cc68096b
cursor-tracker: Kill unused variable
2014-04-17 16:23:37 -04:00
