Jasper St. Pierre
324d7d720d
keybindings: Don't mark a replayed keypress event as handled
...
This is needed so it goes to Wayland clients.
2014-05-07 09:30:22 -04:00
Jasper St. Pierre
413e39ecbb
keybindings: Fix <Super> key crash
...
If we exit early as not handled, then the normal process_event
handler will fire, and trigger the overlay-key binding. As that's
a special binding that doesn't have a handler, trying to trigger
that handler will crash mutter.
Instead of returning early, just check for xdisplay every time
we try to drive the X grab state machine. We really need a better
solution for this on the Wayland side.
2014-05-07 09:30:21 -04:00
Jasper St. Pierre
bca210db45
Revert "Update to latest xdg-shell protocol"
...
This reverts commit fd5c14550a
.
Again, pushed by accident, whoops.
2014-05-05 19:09:07 -04:00
Jasper St. Pierre
bc8799d7d7
constraints: Complete fix for size hints constrainment
2014-05-05 19:06:56 -04:00
Jasper St. Pierre
fd5c14550a
Update to latest xdg-shell protocol
2014-05-05 14:15:03 -04:00
Jasper St. Pierre
a5cca5296c
window: Make sure not to eat any events that end grab ops
...
We need to send the button press / button release that ended a grab
op to Wayland clients so their tracking don't get confused.
2014-05-05 14:15:03 -04:00
Jasper St. Pierre
f4ef4b79f9
constraints: Size increments need to be applied to the client rect
...
Not the frame rect.
2014-05-05 13:10:01 -04:00
Jasper St. Pierre
845fdda22c
keybindings: Make sure not to call meta_change_keygrab under Wayland
2014-05-03 12:50:19 -04:00
Jasper St. Pierre
5d310e06ba
display: Remove some more unnecessary NULL checks
...
Instead, replace them with another assert precondition.
2014-05-02 09:37:01 -04:00
Jasper St. Pierre
25a16c3379
Remove trailing whitespace
2014-05-02 09:34:48 -04:00
Florian Müllner
a6601e92aa
display: Don't grab transient's parent unconditionally
...
Since commit 6e8d1d79d
, move operations are always performed for
the (toplevel) parent of all transient, which is just plain silly
if the dialog is not actually attached to its parent (either because
the dialog is not modal or the setting is disabled).
2014-05-02 12:27:39 +02:00
Jasper St. Pierre
f3a2bb7779
window: Clean up old_rect handling a tiny bit
...
We need the old rect for two purposes: to find the x/y in a resize-only
action, and to pass into the constraints code for nefarious purposes.
The constraints code takes a frame rectangle, so we convert the original
client rect into a frame rect, but never convert it back since it's
unused for the rest of the function.
Instead of playing games with the variables, just have two,
separately-scoped variables. One is the client rect, the other is the
frame rect.
2014-05-01 19:50:39 -04:00
Jasper St. Pierre
73e2d7049a
window: Rearrange code a tiny bit
2014-05-01 19:50:38 -04:00
Jasper St. Pierre
a6353944f6
constraints: Remove a lie
...
The orig / new now are about the frame rect, not the inner window
rect.
2014-05-01 19:50:38 -04:00
Jasper St. Pierre
43d6088ebb
window: Change meta_window_move_resize_internal to take a MetaRectangle
...
We construct one anyway, and most callers already pass in a rectangle
the long way around, so why not change the internal API?
2014-05-01 19:13:33 -04:00
Jasper St. Pierre
06ca99c3a3
window: Remove some ugly debug logging
2014-05-01 17:59:50 -04:00
Jasper St. Pierre
4b5593c67f
window: Make the x/y position in the requested_rect more accurate
...
For gravity-based resizing, we need to make sure that the requested
rectangle has the proper x/y position given by the gravity resize,
rather than the bogus root_x_nw / root_y_nw parameter.
Make the test for this more explicit.
2014-05-01 17:59:50 -04:00
Jasper St. Pierre
acb3dc6754
window: Move adjust_for_gravity to window-x11
...
This removes the weirdness about which edge cases are where in the
move_resize_internal API, and we now always pass in client top-left
coordinates.
2014-05-01 17:59:49 -04:00
Jasper St. Pierre
4c21a46452
window: Move the session restoration and post-manage move_resize to window-x11
2014-05-01 17:59:49 -04:00
Jasper St. Pierre
900ae2c1fa
window: Remove the borders parameter from adjust_for_gravity
...
We can simply use the existing cached borders.
2014-05-01 17:59:49 -04:00
Jasper St. Pierre
01b6445708
window: Simplify adjust_for_gravity
2014-05-01 17:59:49 -04:00
Jasper St. Pierre
292d502205
window: Fix typo in comment
2014-05-01 17:59:49 -04:00
Jasper St. Pierre
adf2e44a82
core: Remove a few unused meta_core functions
2014-05-01 17:59:48 -04:00
Jasper St. Pierre
d456e68375
keybindings: Fix another place we unfreeze on the wrong xdisplay
2014-04-30 09:32:51 -04:00
Jasper St. Pierre
03efa3ccbc
keybindings: Make sure to unfreeze the keyboard on the right xdisplay
...
This fixes keybindings getting "stuck" after being activated in
X11 compositor mode.
2014-04-30 09:32:51 -04:00
Jasper St. Pierre
2101c8357b
Move sync_request_* handling mostly to window-x11
2014-04-29 17:58:23 -04:00
Jasper St. Pierre
575963bee7
window: Turn grab_op_begin / grab_op_ended into vfuncs
...
And move the grab_resize_popup management to the X11 window class,
as this is only used under X11.
2014-04-29 17:58:22 -04:00
Jasper St. Pierre
7726001d43
window: Simplify resize_popup handling
2014-04-29 17:58:22 -04:00
Jasper St. Pierre
e382a4b560
window: Replace manual switch statement for a resizing grab op
2014-04-29 17:58:22 -04:00
Jasper St. Pierre
70713cc7db
window: Add some hooks for when grab ops begin / end on windows
2014-04-29 17:58:22 -04:00
Jasper St. Pierre
417090f3fa
window: Remove some superfluous uses of window->xwindow
2014-04-29 17:58:21 -04:00
Jasper St. Pierre
9fcc57cdec
core: Remove unused function
2014-04-29 17:58:21 -04:00
Jasper St. Pierre
7bf0c77193
window: Move _NET_WM_ALLOWED_ACTIONS setting to window-x11 as well
2014-04-29 17:58:21 -04:00
Jasper St. Pierre
f2328f1105
window: Move meta_window_move_resize_request to window-x11
2014-04-29 17:58:21 -04:00
Florian Müllner
d9a2443e53
Fix crash when cursor theme lookup failed
...
meta_cursor_reference_from_theme() may return %NULL on failure,
in which case we currently crash when trying to release it.
2014-04-29 22:20:03 +02:00
Jasper St. Pierre
8461b2c910
window: Move move_resize_wayland to window-wayland.c
...
The move/resize logic is still busted for top/left resizes... sigh.
2014-04-28 18:22:55 -04:00
Jasper St. Pierre
9b760dbbab
window: Remove unused condition
...
IS_WAYLAND_RESIZE will always result in a RESIZED result, at least.
2014-04-28 18:22:55 -04:00
Jasper St. Pierre
8b0747786a
window: Move X11 struts implementation to X11 codepath
2014-04-28 17:34:33 -04:00
Jasper St. Pierre
41235fcb86
keybindings: Remove now-unused meta_screen_grab_all_keys
2014-04-28 17:34:33 -04:00
Jasper St. Pierre
1d5b4e5b2f
display: Remove the same checks in end_grab_op
2014-04-28 17:34:32 -04:00
Jasper St. Pierre
6e8d1d79d1
display: Make sure to retrieve the toplevel transient for
...
If we have multiple modal stacked dialogs, move the top one, not
the immediate parent, which heavily confuses mutter.
2014-04-28 17:34:32 -04:00
Jasper St. Pierre
7cefe91c3c
display: Fix tiling when grabbing an attached dialog
...
It seems we used the wrong variable by accident
2014-04-28 17:34:32 -04:00
Jasper St. Pierre
1ef6a5542a
display: Remove extraneous checks for grab_window
...
We assert a few lines down anyway, so just move the asserts up
and kill the if statement.
2014-04-28 17:34:32 -04:00
Jasper St. Pierre
bc0f7def47
display: Clean up whitespace
2014-04-28 17:34:31 -04:00
Jasper St. Pierre
f0175d1234
window: Don't reset pending_compositor_effect too early
...
With our surface_mapped strategy, implement_showing might not
change whether the window has been shown or not, and thus we
might end up clearing pending_compositor_effect before the window
is mapped.
Only clear pending_compositor_effect when the effect has actually
been used.
2014-04-28 16:59:34 -04:00
Jasper St. Pierre
2209eac2bf
constraints: Make meta_window_constrain take window geometry rects
...
Remove extend_by_frame and unextend_by_frame. Use a dumb hack in
window.c to translate into window geometry in back. We'll soon track
all rectangles in MetaWindow in terms of the window geometry.
2014-04-28 16:11:09 -04:00
Adel Gadllah
4e584c2cf0
display: Don't call x11 backend code when running native
...
https://bugzilla.gnome.org/show_bug.cgi?id=729044
2014-04-27 20:24:15 +02:00
Rico Tzschichholz
ca75513880
prefs: Add center-new-windows setting
2014-04-25 15:26:24 +02:00
Jasper St. Pierre
14f839c53c
window: Only grab/ungrab buttons/keys on X11 windows
2014-04-24 16:26:21 -04:00
Jasper St. Pierre
ebb6847bd1
ui: Don't use grab ops for grab negotation
...
Grab operations are now always taken on the backend connection, and
this breaks GTK+'s event handling.
Instead of taking a grab op, just do the handling ourselves. The
GTK+ connection will get an implicit grab, which means pointer /
keyboard events won't be sent to the rest of mutter, which is good.
2014-04-24 13:36:40 -04:00