Don't do stacking for override-redirect windows

Don't add override-redirect windows to MetaStack; we shouldn't
be restacking them.

Since we *aren't* stacking the override-redirect windows, we need to
be careful that to ignore them when looking for the top managed
window.

http://bugzilla.gnome.org/show_bug.cgi?id=585984

src/core/stack.c

@@ -1015,8 +1015,11 @@ raise_window_relative_to_managed_windows (MetaScreen *screen,
            * to be moved below.
            */
         }
-      else if (meta_display_lookup_x_window (screen->display,
-                                             children[i]) != NULL)
+      else
+        {
+          MetaWindow *other = meta_display_lookup_x_window (screen->display,
+                                                            children[i]);
+          if (other != NULL && !other->override_redirect)
             {
               XWindowChanges changes;
 
@@ -1041,6 +1044,7 @@ raise_window_relative_to_managed_windows (MetaScreen *screen,
 
               break;
             }
+        }
 
       --i;
     }

src/core/window-props.c

@@ -1435,6 +1435,7 @@ reload_transient_for (MetaWindow    *window,
   meta_window_recalc_window_type (window);
 
   /* update stacking constraints */
+  if (!window->override_redirect)
     meta_stack_update_transient (window->screen->stack, window);
 
   /* possibly change its group. We treat being a window's transient as

src/core/window.c

@@ -955,8 +955,11 @@ meta_window_new_with_attrs (MetaDisplay       *display,
    * and thus constraints may try to auto-fullscreen it which also
    * means restacking it.
    */
+  if (!window->override_redirect)
     meta_stack_add (window->screen->stack,
                     window);
+  else
+    window->layer = META_LAYER_OVERRIDE_REDIRECT; /* otherwise set by MetaStack */
 
   /* Put our state back where it should be,
    * passing TRUE for is_configure_request, ICCCM says
@@ -1311,6 +1314,7 @@ meta_window_unmanage (MetaWindow  *window,
     }
 #endif
 
+  if (!window->override_redirect)
     meta_stack_remove (window->screen->stack, window);
 
   if (window->frame)