isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2024-11-21 15:40:41 -05:00
Code Issues Packages Projects Releases Wiki Activity

background-image: Properly clear the failed to be filled texture pointer

Browse Source 
Otherwise we'll unref and effectively free it, eventually resulting in
use after free, causing wierd issues like crashes and infinite
recursions.

Related: https://bugzilla.redhat.com/show_bug.cgi?id=1989726
Part-of: <https://gitlab.gnome.org/GNOME/mutter/-/merge_requests/1979>
This commit is contained in:
Jonas Ådahl 2021-08-31 09:47:59 +02:00
parent 04994ebddf
commit ef8c428ef9
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/compositor/meta-background-image.c
View File

@ -199,8 +199,9 @@ file_loaded (GObject *source_object,
pixels, 0,
&local_error))
{
g_warning ("Failed to create texture for background");
cogl_object_unref (texture);
g_warning ("Failed to create texture for background: %s",
local_error->message);
cogl_clear_object (&texture);
}
image->texture = texture;