isa/mutter
1
0
Fork 0
mirror of https://github.com/brl/mutter.git synced 2025-01-23 18:09:10 +00:00
Code Issues Packages Projects Releases Wiki Activity

frames.c: Do not create pixmaps when there's nothing to draw

Browse Source 
https://bugzilla.gnome.org/show_bug.cgi?id=630203

Take advantage of existing handling for CachedFramePiece.piece == NULL
to avoid generating pixmaps when width/height are 0
This commit is contained in:
Benjamin Otte 2010-09-20 20:44:23 +02:00
parent afd3b96e2e
commit ecf812db83
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/ui/frames.c
View File

@ -2115,13 +2115,17 @@ generate_pixmap (MetaFrames *frames,
MetaRegion *region;
GdkPixmap *result;
/* do not create a pixmap for nonexisting areas */
if (rect.width <= 0 || rect.height <= 0)
return NULL;
rectangle.x = rect.x;
rectangle.y = rect.y;
rectangle.width = MAX (rect.width, 1);
rectangle.height = MAX (rect.height, 1);
rectangle.width = rect.width;
rectangle.height = rect.height;
result = gdk_pixmap_new (frame->window,
rectangle.width, rectangle.height, -1);
rect.width, rect.height, -1);
clear_backing (result, frame->window, rectangle.x, rectangle.y);
@ -2200,6 +2204,8 @@ populate_cache (MetaFrames *frames,
for (i = 0; i < 4; i++)
{
CachedFramePiece *piece = &pixels->piece[i];
/* generate_pixmap() returns NULL for 0 width/height pieces, but
* does so cheaply so we don't need to cache the NULL return */
if (!piece->pixmap)
piece->pixmap = generate_pixmap (frames, frame, piece->rect);
}